Open
Conversation
Merged into requirements.txt and eliminated the need for redundant "requirement_version.txt"
Eliminated the need for redundant "requirement_version.txt", which also saves initial load time.
Removed redundant code, cleaned up logic, fixed order-of-operation issues (was causing modules not to be found), and troubleshooting.
Expanded try/except statement to catch possible AttributeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose: to resolve initial setup issues.
Tested on Clean install of Python 3.8 and clean pull.
Windows 10.0.19044.2130, NVIDIA A2000 12GB, Chrome
Notes: Even with debugging, the code still fails first run with "AttributeError: 'WindowsPath' object has no attribute 'rstrip'" error. However, everything works after re-running (first setup). This error needs further investigation (seems to be isolated to memory_monitor()). This will be the next thing to tackle, then change some structure, and then work on some basic UI.
Launch.py - Removed redundant code, cleaned up logic, fixed order-of-operation issues (was causing modules not to be found), and troubleshooting.
Requirements.txt - Eliminated the need for redundant "requirement_version.txt", which also saves initial load time.
Installing.py - Expanded try/except statement to catch possible AttributeError.