Conversation
forshev
force-pushed
the
290-use-docs-filter
branch
from
14e5d7f to
9eadbb5
Compare
forshev
changed the base branch from
290-docs-filter
to
290-docs-filter-read-path
forshev
force-pushed
the
290-docs-filter-read-path
branch
from
5cb9698 to
7f1ecc3
Compare
forshev
force-pushed
the
290-use-docs-filter
branch
from
9eadbb5 to
bfad0e9
Compare
forshev
force-pushed
the
290-use-docs-filter
branch
from
6651e64 to
6001327
Compare
|
@seqbenchbot up main search-keyword-exact-match-warm |
|
Oh-oh, @cheb0 Something went wrong and I couldn't process your request. |
| return node.BuildORTree(lidsTids), nil | ||
| } | ||
|
|
||
| func evalTombstones(root, tombstonesIterator node.Node, stats *searchStats) node.Node { |
There was a problem hiding this comment.
So, we always wrap a tree into nAnd node with (most of time) empty tombestone iterator. I decided to check if there is a noticeable perf overhead.
For relatively dense histogram (service:X and level:Y) fired against 3 stg fracs It went from 44-46 ms to 46-50 ms (hot case). I used testDocsFilter from fraction_test
| "github.com/ozontech/seq-db/util" | ||
| ) | ||
|
|
||
| type DocsFilter interface { |
There was a problem hiding this comment.
nit (naming): doesn't look like a guy can filter docs. Since, it's able to get tombestone iterator and delete tombstones for a provided frac, It looks like a tombstone storage/provider to me.
| "github.com/ozontech/seq-db/tokenizer" | ||
| ) | ||
|
|
||
| type testDocsFilter struct{} |
There was a problem hiding this comment.
nit: technically it's possible to test deletion in this test. We could just modify testDocsFilter by allowing it to have deleted lids preconfigured and then add this filter as a field of FractionTestSuite. In a test it's possible to just preconfigure some lids deleted (let's say first 3), then bulk insert and if some docs are missing. Maybe I'll add it later.
4 participants
Description
Use DocsFilter struct in search and fetch
Fixes #290
If you have used LLM/AI assistance please provide model name and full prompt: