Open
Conversation
forshev
force-pushed
the
290-docs-filter
branch
from
0506ad3 to
98257ad
Compare
forshev
force-pushed
the
290-docs-filter-read-path
branch
from
5cb9698 to
7f1ecc3
Compare
cheb0
reviewed
Mar 31, 2026
| init bool | ||
| } | ||
|
|
||
| func NewMergedIterator(a, b node.Node) node.Node { |
Collaborator
There was a problem hiding this comment.
how much it is different from nodeOr?
I only see laziness (it doesn't call children's Next on creation, but I'm planning to add it to nodeOr and the other nodes, and there should be no problem adding it in this PR)
Or it's different String() print you need?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add read path methods to DocsFilter
If you have used LLM/AI assistance please provide model name and full prompt: