Open
Conversation
Member
|
First issue here is that using META_ADD and META_MERGE for the same fields is currently partly broken in EUMM. This was fixed in the 7.06 release, but was reverted along with everything else for 7.08/7.10. Still waiting on a new release that includes the fix. (Perl-Toolchain-Gang/ExtUtils-MakeMaker@91b7ff8) So if the Makefile.PL used META_MERGE to specify resources, it will give bad results. This is why so far I've avoided modifying metadata in Distar. I'm not a huge fan of forcing meta v2, but since it would only happen if you used this function it wouldn't be a huge issue. It would mean that the version would be specified differently when run on a user's machine, but META_ADD/META_MERGE are already ignored in that case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebase of kentfredric/Distar-old#1
Adds a
github %SPECoption visible in Makefile.PL.incgithub user => 'Foo'assumes the distname and combines with user foo to generate a github metadatagithub path => 'Foo/RepoNameHere'forces a pre-calculated path for less lazy peoplegithub issues => 1, user => 'Foo', as above, but also sets up github for issues.ENV{DISTAR_INIT_GITHUB_USER}being set duringdistar-initgenerates aMakefile.PL.incwith github values pre-populated.ENV{DISTAR_INIT_GITHUB_USER}being true duringdistar-initalso initialises github issues support in conjunction with the above.