Remove expensive safety combination Table#2818
Closed
aldexis wants to merge 2 commits intoxb/memoize_safety_evalfrom
Closed
Remove expensive safety combination Table#2818aldexis wants to merge 2 commits intoxb/memoize_safety_evalfrom
aldexis wants to merge 2 commits intoxb/memoize_safety_evalfrom
Conversation
Contributor
Author
|
This didn't bring the benefits I hoped it would, so closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
After #2812, JFRs show that we still spend a large amount of time getting results from the precomputed combination table. This is because it's dealing with objects, so we need to compute their hashcode and get the values in the map. Instead, we can use our own internal table, based on an array and the actual underlying enum values (similar to what an EnumMap would do, but mapping two keys instead).
After this PR
==COMMIT_MSG==
Remove expensive safety combination Table
==COMMIT_MSG==
Possible downsides?