When prompting, use show_default as the default if its a string#2837
Closed
thejcannon wants to merge 9 commits intopallets:mainfrom
thejcannon:patch-1
Closed
When prompting, use show_default as the default if its a string#2837thejcannon wants to merge 9 commits intopallets:mainfrom thejcannon:patch-1
show_default as the default if its a string#2837thejcannon wants to merge 9 commits intopallets:mainfrom
thejcannon:patch-1
Conversation
Author
|
oh duh, this changes the default 🤦 . Gotta go deeper... |
Rowlando13
reviewed
Aug 23, 2025
| if type is not None and show_choices and isinstance(type, Choice): | ||
| prompt += f" ({', '.join(map(str, type.choices))})" | ||
| if isinstance(show_default, str): | ||
| default = f"({show_default})" |
Collaborator
There was a problem hiding this comment.
This should be `default = f"{prompt} ({show_default})". Also add this to the test.
Collaborator
|
Please rebase on main to resolve the changes.rst. With merge after #3030. |
Collaborator
|
A PR is ready to be merged at: #3165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just makes sure the
defaulthanded to.promptis theshow_defaultif its a string (to match the help).fixes #2836
should fail without the change.
.. versionchanged::entries in any relevant code docs.