Fix explorer /select with spaces on Windows (#2994)#3216
Closed
SamrudhNR wants to merge 6 commits intopallets:mainfrom
Closed
Fix explorer /select with spaces on Windows (#2994)#3216SamrudhNR wants to merge 6 commits intopallets:mainfrom
SamrudhNR wants to merge 6 commits intopallets:mainfrom
Conversation
Use string command with inner quotes around path instead of list args to ensure correct parsing when path contains spaces. Prevents fallback to Documents folder. Tests pass locally. References pallets#2994.
…/click into fix/2994-launch-spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix explorer /select with spaces on Windows
Closes #2994
Problem
On Windows,
click.launch(path, locate=True)fails to select files or folders when the path contains spaces. Explorer opens the user's Documents folder instead of selecting the target.Cause
When passing arguments as a list to
subprocess.call,list2cmdlinewraps the entire/select,<path>part in outer quotes. This confusesexplorer.exe's parser, causing it to ignore the path.Fix
Build the command as a single string with quotes placed only around the path: