fix _AtomicFile.close ignoring delete parameter#3221
Closed
bysiber wants to merge 1 commit intopallets:mainfrom
Closed
fix _AtomicFile.close ignoring delete parameter#3221bysiber wants to merge 1 commit intopallets:mainfrom
bysiber wants to merge 1 commit intopallets:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_AtomicFile.close()accepts adeleteparameter, and__exit__passesdelete=Truewhen an exception occurs during the context manager block. However, theclosemethod unconditionally callsos.replace, moving the (potentially incomplete) temp file over the original regardless of whetherdeleteisTrue.This defeats the purpose of atomic writes — if an error occurs while writing, the original file should be preserved and the temp file should be cleaned up instead.
This change makes
closecheck thedeleteflag. WhenTrue, it removes the temp file withos.unlinkrather than replacing the original. Theos.unlinkcall is wrapped in a try/except to handle cases where the temp file may have already been removed.