close mkstemp fd before reopening file in _tempfilepager#3222
Closed
bysiber wants to merge 1 commit intopallets:mainfrom
Closed
close mkstemp fd before reopening file in _tempfilepager#3222bysiber wants to merge 1 commit intopallets:mainfrom
bysiber wants to merge 1 commit intopallets:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_tempfilepagercreates a temporary file usingtempfile.mkstemp(), which returns an open file descriptor. However, the file is then re-opened viaopen_stream(filename, "wb")for writing without closing the originalfdfirst.The original
fdstays open for the duration of the write and the entire subprocess call, only being closed in thefinallyblock. This is a resource leak and can cause issues on Windows where open file descriptors prevent other processes from accessing the file — the pager subprocess may not be able to read the temp file.This moves the
os.close(fd)call to immediately aftermkstemp(), before the file is re-opened for writing.