Add cross-reference to tests from test_defaults.py#3223
Open
kdeldycke wants to merge 1 commit intopallets:mainfrom
Open
Add cross-reference to tests from test_defaults.py#3223kdeldycke wants to merge 1 commit intopallets:mainfrom
test_defaults.py#3223kdeldycke wants to merge 1 commit intopallets:mainfrom
Conversation
kdeldycke
force-pushed
the
test-cross-refs
branch
from
d24e5e1 to
f622664
Compare
kdeldycke
force-pushed
the
test-cross-refs
branch
from
f622664 to
0480a56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #3145 I reviewed tests from
test_defaults.pyand discovered some sibling tests dispersed in Click test suite.This PR is updating these tests to cross-reference them. I used this opportunity to augment the
test_basic_defaultstest with some more values to augment its coverage.If other maintainers find these tests too similar or misplaced, I can push this PR a bit more towards moving these tests between files, merge some, or even goes further and refactor them.