Skip to content

fix: Context menu submenu offset incorrect for last item #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dblythy wants to merge 2 commits into
base: alpha
Choose a base branch
from
+16 −4
Open

fix: Context menu submenu offset incorrect for last item #3262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9275473
fix: Context menu submenu offset incorrect for last item (#2635)
dblythy Mar 13, 2026
610f7c0
fix: add null guard for closest('ul') in ContextMenu hover handler
dblythy Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/components/ContextMenu/ContextMenu.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import PropTypes from 'lib/PropTypes';
import React, { useState, useEffect, useRef } from 'react';
import React, { useState, useEffect, useLayoutEffect, useRef } from 'react';
import styles from 'components/ContextMenu/ContextMenu.scss';

const getPositionToFitVisibleScreen = (ref, offset = 0) => {
Expand Down Expand Up @@ -65,7 +65,7 @@ const MenuSection = ({ level, items, path, setPath, hide, hoveredItemOffset }) =
const basePosition = useRef(null);
const initialParentScrollTop = useRef(0);

useEffect(() => {
useLayoutEffect(() => {
// Use the actual pixel offset of the hovered item instead of index-based calculation
const newPosition = getPositionToFitVisibleScreen(sectionRef, hoveredItemOffset);
if (newPosition) {
Expand Down Expand Up @@ -110,7 +110,11 @@ const MenuSection = ({ level, items, path, setPath, hide, hoveredItemOffset }) =
opacity: 1,
position: 'absolute',
}
: {};
: {
opacity: 0,
position: 'absolute',
pointerEvents: 'none',
};

return (
<ul ref={sectionRef} className={styles.category} style={style}>
Expand All @@ -119,8 +123,16 @@ const MenuSection = ({ level, items, path, setPath, hide, hoveredItemOffset }) =
const newPath = path.slice(0, level + 1);
newPath.push(index);
// Get the actual pixel offset of the hovered item relative to its parent
// Using getBoundingClientRect for accuracy regardless of offsetParent chain
const itemElement = event.currentTarget;
const itemOffset = itemElement.offsetTop;
const parentElement = itemElement.closest('ul');
if (!parentElement) {
setPath(newPath, 0);
return;
}
const itemRect = itemElement.getBoundingClientRect();
const parentRect = parentElement.getBoundingClientRect();
const itemOffset = itemRect.top - parentRect.top + parentElement.scrollTop;
setPath(newPath, itemOffset);
};

Expand Down
Loading