Issue #167 - valid email-addresses with IDNs do not validate#188
Open
sprak3000 wants to merge 2 commits intoparticle-php:masterfrom
Open
Issue #167 - valid email-addresses with IDNs do not validate#188sprak3000 wants to merge 2 commits intoparticle-php:masterfrom
sprak3000 wants to merge 2 commits intoparticle-php:masterfrom
Conversation
* Use a regexp to allow international characters throughout e-mail address. * Update tests accordingly.
peter279k
reviewed
Oct 19, 2018
* Removing comment per PR feedback.
RobQuistNL
suggested changes
Jan 7, 2019
| ['berry+plus-sign@github.com.museum'], | ||
| ['berry@githüb.com'], | ||
| ['bërry@github.com'] | ||
| ]; |
Contributor
There was a problem hiding this comment.
You might want to add some more emailadresses to check, as well as some (much more) invalid e-mail adresses. Since this is quite a big change, you know :)
There was a problem hiding this comment.
Like @RobQuistNL says, this validation approach is the big change because the original approach uses the native filter function to validate e-mail address. And the new change use the regular expression.
I agree with @RobQuistNL, and It should add more tests to prove the regular expression can validate e-mail address currently 👍.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
idn_to_ascii()from thephp-intlextension.Checklist
Linked issue
#167