Move the addition of reflection log classes to Options.postProcess#213
Closed
jjppp wants to merge 1 commit intopascal-lab:masterfrom
Closed
Move the addition of reflection log classes to Options.postProcess#213jjppp wants to merge 1 commit intopascal-lab:masterfrom
Options.postProcess#213jjppp wants to merge 1 commit intopascal-lab:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
=========================================
Coverage 75.69% 75.69%
+ Complexity 4668 4661 -7
=========================================
Files 482 482
Lines 16147 16143 -4
Branches 2203 2202 -1
=========================================
- Hits 12222 12220 -2
+ Misses 3059 3057 -2
Partials 866 866
🚀 New features to boost your workflow:
|
This commit involves 3 changes: 1. The type of `Options.analyses` is changed from `Map<String, String>` to `Map<String, AnalysisOptions>`. This means the parsing logic of `AnalysisOptions` is moved from `PlanConfig` to `Options` via picocli converters. 2. The logic of adding classes in the reflection log is moved from `SootWorldBuilder` to `Options.postProcess`. This leaves world builders now unaware of reflection and analyses. 3. `WorldBuilder.build` does not need its `analyses` argument anymore, since `AnalysisOptions` can be now accessed via `Options`. This simplifies the interface of all world builders.
821eabd to
b784be4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address the need for adding classes from the reflection log to the closed-world for different frontends in a uniform way, by making 3 following changes:
Options.analysesis changed fromMap<String, String>toMap<String, AnalysisOptions>. This is because accessing reflection logs requiresAnalysisOptions, but they are not accessible until the processing ofOptionsis done. Moving the parsing logic ofAnalysisOptionsfromPlanConfigtoOptionsvia picocli converters simplifiesPlanConfigwhile makingOptionscohesive.SootWorldBuildertoOptions.postProcess. This leaves world builders now unaware of reflection and analyses.WorldBuilder.builddoes not need itsanalysesargument anymore, sinceAnalysisOptionscan be now accessed viaOptions. This simplifies the interface of all world builders.