fix(tools)!: deps: remove glob, update peers#2958
Merged
bennypowers merged 3 commits intomainfrom Dec 26, 2025
Merged
Conversation
Requires nodejs >= v22
🦋 Changeset detectedLatest commit: 8bf5e54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(tools)!: deps: remove glob, update peers"
} |
There was a problem hiding this comment.
Pull request overview
This PR removes the dependency on the glob npm package by migrating to Node.js's built-in glob function from node:fs/promises, which requires Node.js >= v22. The PR also updates numerous peer dependencies to newer versions.
Key changes:
- Replaces
globpackage imports withnode:fs/promisesglob API across multiple files - Updates Node.js requirement to >= v22 in the changeset
- Updates 40+ peer dependency versions in package.json
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/pfe-tools/package.json | Updates peer dependencies to newer versions and implicitly removes glob dependency |
| tools/pfe-tools/dev-server/plugins/import-map-generator.ts | Migrates from glob package to node:fs/promises glob API with async iteration |
| tools/pfe-tools/custom-elements-manifest/lib/get-all-packages.ts | Migrates from glob package to node:fs globSync and implements custom hasMagic function |
| tools/pfe-tools/11ty/plugins/todos.cjs | Migrates from glob package to fs/promises glob with Array.fromAsync wrapper |
| tools/pfe-tools/11ty/plugins/custom-elements-manifest.cjs | Migrates from glob package to node:fs/promises glob with Array.fromAsync wrapper |
| package-lock.json | Updates lock file to reflect new peer dependency versions and their transitive dependencies |
| .changeset/short-numbers-double.md | Documents the breaking change requiring Node.js >= 22 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bennypowers
changed the title
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires nodejs >= v22