Replace is_wizard with more generic groups#39
Open
hellcp wants to merge 1 commit intopebble-dev:masterfrom
Open
Replace is_wizard with more generic groups#39hellcp wants to merge 1 commit intopebble-dev:masterfrom
hellcp wants to merge 1 commit intopebble-dev:masterfrom
Conversation
jwise
reviewed
Apr 19, 2026
Contributor
There was a problem hiding this comment.
array of text groups kind of bothers me, I wish it was array of group IDs that join into a table that could potentially provide semantic meaning by adding columns to that table. otherwise it is not really better (arguably, worse?) than one bool column on the user structure per capability
Member
Author
I don't like arrays in sql in general, so I would be really happy to just set up a many to many relationship here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untested