add failing test cases for extracting scripts from html entry points#86
Open
lmmarsano wants to merge 1 commit intopeerigon:masterfrom
Open
add failing test cases for extracting scripts from html entry points#86lmmarsano wants to merge 1 commit intopeerigon:masterfrom
lmmarsano wants to merge 1 commit intopeerigon:masterfrom
Conversation
fails to extract scripts for html entry points raises an exception when those scripts are ES modules pertains to peerigon#79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #79
The loader fails to extract scripts for html entry points, and raises an exception when those scripts are ES modules.
These tests expose the issue to help get fixes started.
Please redirect the merge into a new branch to complete the fixes there.