Skip to content

Fix: Error from multireference read only #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samhere06 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Error from multireference read only #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lib/_components/template/multi-reference-readonly/multi-reference-readonly.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div>
<h3 style="font-weight: bold; margin: 0">{{ label }}</h3>
<component-mapper name="SimpleTable" [props]="{ pConn$ }"></component-mapper>
<component-mapper name="SimpleTable" [props]="{ pConn$: newPConn.getPConnect() }"></component-mapper>
</div>
27 changes: 27 additions & 0 deletions ...c/lib/_components/template/multi-reference-readonly/multi-reference-readonly.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { AngularPConnectData, AngularPConnectService } from '../../../_bridge/an
import { ComponentMapperComponent } from '../../../_bridge/component-mapper/component-mapper.component';

interface MultiReferenceReadOnlyProps {
readonlyContextList: string;
referenceList: string;
label: string;
hideLabel: boolean;
}
Expand All @@ -21,6 +23,7 @@ export class MultiReferenceReadonlyComponent implements OnInit, OnDestroy {
angularPConnectData: AngularPConnectData = {};
configProps$: MultiReferenceReadOnlyProps;
label: string;
newPConn: any;

constructor(private angularPConnect: AngularPConnectService) {}

Expand Down Expand Up @@ -49,5 +52,29 @@ export class MultiReferenceReadonlyComponent implements OnInit, OnDestroy {
updateSelf() {
this.configProps$ = this.pConn$.getConfigProps() as MultiReferenceReadOnlyProps;
this.label = this.configProps$.label;

const config = (this.pConn$.getMetadata() as any)?.config;
const { referenceList, readonlyContextList } = config;
let readonlyContextObject;
if (!PCore.getAnnotationUtils().isProperty(referenceList)) {
readonlyContextObject = {
referenceList: readonlyContextList
};
}
const hideLabel = this.configProps$.hideLabel ?? false;
this.newPConn = this.pConn$.createComponent(
{
type: 'SimpleTable',
config: {
...config,
...readonlyContextObject,
label: this.label,
hideLabel
}
},
'',
0,
{}
);
}
}
2 changes: 1 addition & 1 deletion packages/angular-sdk-components/src/lib/_components/template/simple-table-manual/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const getContext = thePConn => {
const pageReference = thePConn.getPageReference();
const { readonlyContextList, referenceList = readonlyContextList } = thePConn.getStateProps()?.config || thePConn.getStateProps();

const pageReferenceForRows = referenceList.startsWith('.') ? `${pageReference}.${referenceList.substring(1)}` : referenceList;
const pageReferenceForRows = referenceList?.startsWith('.') ? `${pageReference}.${referenceList?.substring(1)}` : referenceList;
const viewName = thePConn.viewName;

// removing "caseInfo.content" prefix to avoid setting it as a target while preparing pageInstructions
Expand Down