Skip to content

feat:enhance subscription management and context removal in AngularPC… #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tumms2021389 merged 1 commit into from
Feb 11, 2026
Merged

feat:enhance subscription management and context removal in AngularPC… #434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion packages/angular-sdk-components/src/lib/_bridge/angular-pconnect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,17 @@ export class AngularPConnectService {
let fnUnsubscribe;
// console.log( `Bridge subscribing: ${theCompName} `);
if (inComp) {
fnUnsubscribe = this.getStore().subscribe(inCallback);
let bSubscribed = true;
const wrappedCallback = () => {
if (bSubscribed && inCallback) {
inCallback();
}
};
const storeUnsubscribe = this.getStore().subscribe(wrappedCallback);
fnUnsubscribe = () => {
bSubscribed = false;
storeUnsubscribe();
};
}
return fnUnsubscribe;
}
Expand Down Expand Up @@ -283,6 +293,28 @@ export class AngularPConnectService {
if (inComp.pConn$?.removeFormField) {
inComp.pConn$?.removeFormField();
}

const contextName = inComp.pConn$.getContextName();
const pageReference = inComp.pConn$.getPageReference();
const rawConfig = inComp.pConn$._rawConfig;
const index = inComp.pConn$.index;

if (Object.hasOwn(rawConfig?.config ?? {}, 'value') && inComp.pConn$._type !== 'Address') {
PCore.getContextTreeManager().removeFieldNode(
contextName,
pageReference,
inComp.pConn$.viewName || '',
inComp.pConn$._getPropertyName(),
index as number
);
} else if (inComp.pConn$._type === 'Address' && rawConfig?.config?.associatedView) {
// remove address node and its children
PCore.getContextTreeManager().removeViewNode(contextName, pageReference, rawConfig.config.associatedView, index as number);
} else {
// remove view node and its children
const pageRef = rawConfig?.config?.context ? `${pageReference}${rawConfig?.config.context}` : pageReference;
PCore.getContextTreeManager().removeViewNode(contextName, pageRef, rawConfig?.config?.name || rawConfig?.config?.id || '', index);
}
}

// Returns true if the component's entry in ___componentPropsArr___ is
Expand Down