PXB-3606 Backup may succeed with incomplete redo log#1704
Open
JoeJRW wants to merge 1 commit intopercona:trunkfrom
Open
PXB-3606 Backup may succeed with incomplete redo log#1704JoeJRW wants to merge 1 commit intopercona:trunkfrom
JoeJRW wants to merge 1 commit intopercona:trunkfrom
Conversation
Description
===========
The backup log shows "Unable to open #ib_redo (error: 1504)", but the
backup was still successful with "Complete OK!".
Analysis
========
After backing up all files, xtrabackup get last_lsn from
performance_schema.log_status. If an exception occurs when copying to
the last_lsn, such as a redo log purge, xtrabackup does not handle the
error correctly, resulting in a backup set that is missing redo log.
Fix
===
Complete error handling during redo log copying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The backup log shows "Unable to open #ib_redo (error: 1504)", but the
backup was still successful with "Complete OK!".
Analysis
After backing up all files, xtrabackup get last_lsn from
performance_schema.log_status. If an exception occurs when copying to
the last_lsn, such as a redo log purge, xtrabackup does not handle the
error correctly, resulting in a backup set that is missing redo log.
Fix
Complete error handling during redo log copying.