Skip to content

Refactoring#635

Draft
artemgavrilov wants to merge 2 commits intomainfrom
refactoring
Draft

Refactoring#635
artemgavrilov wants to merge 2 commits intomainfrom
refactoring

Conversation

@artemgavrilov
Copy link
Copy Markdown
Contributor

@artemgavrilov artemgavrilov commented Mar 24, 2026

Description

Some refactoring:

  1. Remove redundant argument from pgsm_create_hash_entry function
  2. Move declarations that used in one place to that place (in the same file)
  3. Little cleanup of main header file

Links

Everywhere where we invoke this function we pass just zero. This
argument has no sence as we always fill bucket id later.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.28%. Comparing base (486537b) to head (0a03600).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   85.44%   85.28%   -0.17%     
==========================================
  Files           3        3              
  Lines        1340     1339       -1     
  Branches      217      217              
==========================================
- Hits         1145     1142       -3     
- Misses         92       93       +1     
- Partials      103      104       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Move declarations that used in single file to that file. No need to have
them in main project header file.
@artemgavrilov artemgavrilov marked this pull request as ready for review March 25, 2026 13:13
Copy link
Copy Markdown
Contributor

@AndersAstrand AndersAstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sence->sense in the first commit message.

I think the second commit is an improvement, but I think we should introduce guc.h and hash_query.h to make things even better than having those "sections" in the one h-file.

If you don't feel like doing that we should commit this as is though.

@artemgavrilov
Copy link
Copy Markdown
Contributor Author

sence->sense in the first commit message.

I think the second commit is an improvement, but I think we should introduce guc.h and hash_query.h to make things even better than having those "sections" in the one h-file.

If you don't feel like doing that we should commit this as is though.

Adding separate header files it's what I planned to suggest next 😄

Also what do you think about moving C sources to /src directory?

@artemgavrilov artemgavrilov marked this pull request as draft March 27, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants