Conversation
Everywhere where we invoke this function we pass just zero. This argument has no sence as we always fill bucket id later.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 85.44% 85.28% -0.17%
==========================================
Files 3 3
Lines 1340 1339 -1
Branches 217 217
==========================================
- Hits 1145 1142 -3
- Misses 92 93 +1
- Partials 103 104 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Move declarations that used in single file to that file. No need to have them in main project header file.
a394fff to
0a03600
Compare
AndersAstrand
left a comment
There was a problem hiding this comment.
sence->sense in the first commit message.
I think the second commit is an improvement, but I think we should introduce guc.h and hash_query.h to make things even better than having those "sections" in the one h-file.
If you don't feel like doing that we should commit this as is though.
Adding separate header files it's what I planned to suggest next 😄 Also what do you think about moving C sources to /src directory? |
Description
Some refactoring:
Links