Make sure to load the upgrade script for the future 2.4#648
Open
jeltz wants to merge 2 commits intopercona:mainfrom
Open
Make sure to load the upgrade script for the future 2.4#648jeltz wants to merge 2 commits intopercona:mainfrom
jeltz wants to merge 2 commits intopercona:mainfrom
Conversation
We added an upgrade script for the future 2.4 release in commit 3481ee7 but we never actually bumped the version in the control file so the file was never loaded and therefore the tests were never updated to match dropping the pgsm_create_13_view() function.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
=======================================
Coverage 86.47% 86.47%
=======================================
Files 3 3
Lines 1346 1346
Branches 217 217
=======================================
Hits 1164 1164
Misses 86 86
Partials 96 96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Here is one idea: If there is ongoing SQL changes in This seems less prone to mistakes to me than trying to predict what the next release version will be named. |
Contributor
Author
|
Yeah, my idea was basically call the next version for "development" or "dev". |
9064ab2 to
4b7f51a
Compare
artemgavrilov
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added an upgrade script for the future 2.4 release in commit 3481ee7 but we never actually bumped the version in the control file so the file was never loaded and therefore the tests were never updated to match dropping the
pgsm_create_13_view()function.Questions