Create libvalkey.a static library#2502
Merged
sfeifer merged 1 commit intoperformancecopilot:mainfrom Feb 26, 2026
Merged
Conversation
kmcdonell
reviewed
Feb 25, 2026
Member
kmcdonell
left a comment
kmcdonell
left a comment
There was a problem hiding this comment.
@sfeifer LGTM
I presume in the future libvalkey will get packaged from some project outside PCP as a DSO and then escape through the various distribution repositories, and this change will also make it easier to migrate from the vendor'd library to a DSO when that happens.
kmcdonell
approved these changes
Feb 25, 2026
Member
kmcdonell
left a comment
kmcdonell
left a comment
There was a problem hiding this comment.
Oops, meant Approve, not just a Comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, libvalkey was built for both libpcp_web and pmdavalkey. By changing over to using a static library, libvalkey.a, we are able to simplify the makefiles for libpcp_web and pmdavalkey. We now also have better control over the build for libvalkey with these changes.