Skip to content

[ENHANCEMENT]: Use shared utilities for keyboard shortcuts in plugins#630

Draft
ibakshay wants to merge 1 commit intomainfrom
ibakshay/keyboard-shortcuts
Draft

[ENHANCEMENT]: Use shared utilities for keyboard shortcuts in plugins#630
ibakshay wants to merge 1 commit intomainfrom
ibakshay/keyboard-shortcuts

Conversation

@ibakshay
Copy link
Copy Markdown
Contributor

@ibakshay ibakshay commented Apr 15, 2026

This pull request is part of perses/perses#3347

Description

This Pull Request depends on perses/shared#105

  • Replace duplicated inline Mod+Enter handlers in query editors (ClickHouse, Loki, VictoriaLogs) with the shared createModEnterHandler utility from @perses-dev/components
  • Replace manual navigator.userAgent Mac detection in LogsTable with TanStack's formatForDisplay('Mod') for platform-aware modifier key display

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.

Signed-off-by: Akshay Iyyadurai Balasundaram <akshay.iyyadurai.balasundaram@sap.com>
@ibakshay ibakshay requested a review from a team as a code owner April 15, 2026 06:02
@ibakshay ibakshay requested review from Gladorme and removed request for a team April 15, 2026 06:02
@ibakshay ibakshay marked this pull request as draft April 15, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant