Skip to content

rne_python in mdh module#268

Open
hanm2019 wants to merge 4 commits intopetercorke:masterfrom
hanm2019:master
Open

rne_python in mdh module#268
hanm2019 wants to merge 4 commits intopetercorke:masterfrom
hanm2019:master

Conversation

@hanm2019
Copy link

I find the result is different between rne and rne_python function when I use a MDH module Robot, After review the code, I find two bugs in there, and After update the code, it finally get the same result.

  1. In rne forward, the Rt should dot with all three types of vd
    corrent code:
vd_ = Rt @ _cross(wd, pstar) + _cross(w, _cross(w, pstar)) + vd

should update to:

vd_ = Rt @ (_cross(wd, pstar) + _cross(w, _cross(w, pstar)) + vd)
  1. In rne backward , the Fm should cross with the center of mass , not the pstar
    corrent code:
nn_ = (
                        R @ nn
                        + _cross(pstar, R @ f)
                        + _cross(pstar, Fm[:, j])
                        + Nm[:, j]
)

should update to:

nn_ = (
                        R @ nn
                        + _cross(pstar, R @ f)
                        + _cross(r, Fm[:, j])
                        + Nm[:, j]
)

update the vd rne_python of mdh module.
vd_ = Rt @ (_cross(wd, pstar) + _cross(w, _cross(w, pstar)) + vd)
nn_ = R@nn + pstar x (R @ f) + r x F + N
@hanm2019
Copy link
Author

#266

@Betavion
Copy link

This is right. Please do pull this into the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants