Skip to content

Fixed small issues with music#122

Open
zabidenhtf wants to merge 3 commits intopetitlapin:mainfrom
zabidenhtf:music
Open

Fixed small issues with music#122
zabidenhtf wants to merge 3 commits intopetitlapin:mainfrom
zabidenhtf:music

Conversation

@zabidenhtf
Copy link
Copy Markdown
Contributor

  • Added copyright for my music in main menu (And also updated copyright)
  • Fixed audio volume
  • Fixed music looping
  • Default sound settings a bit changed

@petitlapin
Copy link
Copy Markdown
Owner

Thanks! I just tested and there is still a blank at the end of both in game music, is it possible to take a look at it please?

@zabidenhtf
Copy link
Copy Markdown
Contributor Author

Thanks! I just tested and there is still a blank at the end of both in game music, is it possible to take a look at it please?

I think we can just add fade in and fade out effect

@zabidenhtf
Copy link
Copy Markdown
Contributor Author

Wait for my commit with this change

@zabidenhtf
Copy link
Copy Markdown
Contributor Author

image

Look, why in AUDACITY it loops, but in game no?

@zabidenhtf
Copy link
Copy Markdown
Contributor Author

Done, I added a fade in and fade out for the game music (because I remember you need looping music in the menu)

@petitlapin
Copy link
Copy Markdown
Owner

Done, I added a fade in and fade out for the game music (because I remember you need looping music in the menu)

you only pushed the generated files in the last commit, not the mmpz

@zabidenhtf
Copy link
Copy Markdown
Contributor Author

Done, I added a fade in and fade out for the game music (because I remember you need looping music in the menu)

you only pushed the generated files in the last commit, not the mmpz

I added fade in and fade out using Audacity (not LMMS)

@petitlapin
Copy link
Copy Markdown
Owner

I guess it's not possible with LMMS to add these effects?
It bothers me a bit because it means the audio files are not reproducible if we need to rebuild them from the lmms file. Do we have no way of doing the loop using lmms only?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants