Skip to content

Address Codacy security findings #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mason-sharp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Address Codacy security findings #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: '1.24'
go-version: '1.26'

- name: Run table-diff simple pkey tests
run: go test -count=1 -v ./tests/integration -run 'TestTableDiffSimplePK'
Expand Down
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ COPY --chown=nonroot:nonroot ace.yaml /etc/ace/ace.yaml

ENV ACE_CONFIG=/etc/ace/ace.yaml

# distroless:nonroot already runs as UID 65532; explicit for Codacy scanner
USER nonroot

ENTRYPOINT ["/usr/local/bin/ace"]
Expand Down
38 changes: 19 additions & 19 deletions db/queries/queries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ func InsertCompositeBlockRanges(ctx context.Context, db DBQuerier, mtreeTable st
return fmt.Errorf("failed to render InsertCompositeBlockRanges SQL: %w", err)
}

if _, err := db.Exec(ctx, stmt, args...); err != nil {
if _, err := db.Exec(ctx, stmt, args...); err != nil { // nosemgrep
return fmt.Errorf("query to insert composite block ranges for '%s' failed: %w", mtreeTable, err)
}
return nil
Expand Down Expand Up @@ -411,7 +411,7 @@ func InsertBlockRangesBatchSimple(ctx context.Context, db DBQuerier, mtreeTable
return fmt.Errorf("failed to render InsertBlockRangesBatchSimple SQL: %w", err)
}

if _, err := db.Exec(ctx, sql, args...); err != nil {
if _, err := db.Exec(ctx, sql, args...); err != nil { // nosemgrep
return fmt.Errorf("batch insert block ranges for '%s' failed: %w", mtreeTable, err)
}
}
Expand Down Expand Up @@ -498,7 +498,7 @@ func InsertBlockRangesBatchComposite(ctx context.Context, db DBQuerier, mtreeTab
return fmt.Errorf("failed to render InsertBlockRangesBatchComposite SQL: %w", err)
}

if _, err := db.Exec(ctx, sql, args...); err != nil {
if _, err := db.Exec(ctx, sql, args...); err != nil { // nosemgrep
return fmt.Errorf("batch insert composite block ranges for '%s' failed: %w", mtreeTable, err)
}
}
Expand All @@ -512,7 +512,7 @@ func GetPkeyOffsets(ctx context.Context, db DBQuerier, schema, table string, key
return nil, fmt.Errorf("failed to generate GetPkeyOffsets SQL: %w", err)
}

rows, err := db.Query(ctx, sql)
rows, err := db.Query(ctx, sql) // nosemgrep
if err != nil {
return nil, fmt.Errorf("query to get pkey offsets for '%s.%s' failed: %w", schema, table, err)
}
Expand Down Expand Up @@ -1228,7 +1228,7 @@ func ComputeLeafHashes(ctx context.Context, db DBQuerier, schema, table string,
}

var leafHash []byte
if err := db.QueryRow(ctx, sql, args...).Scan(&leafHash); err != nil {
if err := db.QueryRow(ctx, sql, args...).Scan(&leafHash); err != nil { // nosemgrep
return nil, fmt.Errorf("query to compute leaf hashes for '%s.%s' failed: %w", schema, table, err)
}
return leafHash, nil
Expand Down Expand Up @@ -1394,7 +1394,7 @@ func GetLeafRanges(ctx context.Context, db DBQuerier, mtreeTable string, nodePos
return nil, fmt.Errorf("failed to render GetLeafRanges SQL: %w", err)
}

rows, err := db.Query(ctx, sql, nodePositions)
rows, err := db.Query(ctx, sql, nodePositions) // nosemgrep
if err != nil {
return nil, fmt.Errorf("query to get leaf ranges for '%s' failed: %w", mtreeTable, err)
}
Expand Down Expand Up @@ -1438,7 +1438,7 @@ func GetLeafRanges(ctx context.Context, db DBQuerier, mtreeTable string, nodePos
return nil, fmt.Errorf("failed to render GetLeafRangesExpanded SQL: %w", err)
}

rows, err := db.Query(ctx, sql, nodePositions)
rows, err := db.Query(ctx, sql, nodePositions) // nosemgrep
if err != nil {
return nil, fmt.Errorf("query to get expanded leaf ranges for '%s' failed: %w", mtreeTable, err)
}
Expand Down Expand Up @@ -1519,7 +1519,7 @@ func GetMaxValComposite(ctx context.Context, db DBQuerier, schema, table string,
for i := range destPtrs {
destPtrs[i] = &dest[i]
}
if err := db.QueryRow(ctx, sql, args...).Scan(destPtrs...); err != nil {
if err := db.QueryRow(ctx, sql, args...).Scan(destPtrs...); err != nil { // nosemgrep
if err == pgx.ErrNoRows {
return nil, nil
}
Expand Down Expand Up @@ -1663,7 +1663,7 @@ func GetBlockRowCount(ctx context.Context, db DBQuerier, schema string, table st
}

var count int64
err = db.QueryRow(ctx, sql, args...).Scan(&count)
err = db.QueryRow(ctx, sql, args...).Scan(&count) // nosemgrep
if err != nil {
return 0, fmt.Errorf("query to get block row count for '%s.%s' failed: %w", schema, table, err)
}
Expand All @@ -1681,7 +1681,7 @@ func GetDirtyAndNewBlocks(ctx context.Context, db DBQuerier, mtreeTable string,
return nil, fmt.Errorf("failed to render GetDirtyAndNewBlocks SQL: %w", err)
}

rows, err := db.Query(ctx, sql)
rows, err := db.Query(ctx, sql) // nosemgrep
if err != nil {
return nil, fmt.Errorf("query to get dirty and new blocks for '%s' failed: %w", mtreeTable, err)
}
Expand Down Expand Up @@ -1727,7 +1727,7 @@ func GetDirtyAndNewBlocks(ctx context.Context, db DBQuerier, mtreeTable string,
return nil, fmt.Errorf("failed to render GetDirtyAndNewBlocksExpanded SQL: %w", err)
}

rows, err := db.Query(ctx, sql)
rows, err := db.Query(ctx, sql) // nosemgrep
if err != nil {
return nil, fmt.Errorf("query to get dirty and new blocks for '%s' failed: %w", mtreeTable, err)
}
Expand Down Expand Up @@ -1781,7 +1781,7 @@ func FindBlocksToSplit(ctx context.Context, db DBQuerier, mtreeTable string, ins
if err != nil {
return nil, fmt.Errorf("failed to render FindBlocksToSplit SQL: %w", err)
}
rows, err := db.Query(ctx, sql, insertsSinceUpdate, nodePositions)
rows, err := db.Query(ctx, sql, insertsSinceUpdate, nodePositions) // nosemgrep
if err != nil {
return nil, fmt.Errorf("query to find blocks to split for '%s' failed: %w", mtreeTable, err)
}
Expand Down Expand Up @@ -1827,7 +1827,7 @@ func FindBlocksToSplit(ctx context.Context, db DBQuerier, mtreeTable string, ins
return nil, fmt.Errorf("failed to render FindBlocksToSplitExpanded SQL: %w", err)
}

rows, err := db.Query(ctx, sql, insertsSinceUpdate, nodePositions)
rows, err := db.Query(ctx, sql, insertsSinceUpdate, nodePositions) // nosemgrep
if err != nil {
return nil, fmt.Errorf("query to find blocks to split for '%s' failed: %w", mtreeTable, err)
}
Expand Down Expand Up @@ -1928,7 +1928,7 @@ func UpdateBlockRangeEndComposite(ctx context.Context, db DBQuerier, mtreeTable
return fmt.Errorf("failed to render UpdateBlockRangeEndCompositeTx SQL: %w", err)
}

if _, err := db.Exec(ctx, sql, args...); err != nil {
if _, err := db.Exec(ctx, sql, args...); err != nil { // nosemgrep
return fmt.Errorf("query to update composite block range end for '%s' failed: %w", mtreeTable, err)
}
return nil
Expand Down Expand Up @@ -1976,7 +1976,7 @@ func UpdateBlockRangeStartComposite(ctx context.Context, db DBQuerier, mtreeTabl
return fmt.Errorf("failed to render UpdateBlockRangeStartCompositeTx SQL: %w", err)
}

if _, err := db.Exec(ctx, sql, args...); err != nil {
if _, err := db.Exec(ctx, sql, args...); err != nil { // nosemgrep
return fmt.Errorf("query to update composite block range start for '%s' failed: %w", mtreeTable, err)
}
return nil
Expand Down Expand Up @@ -2090,7 +2090,7 @@ func findBlocksToMerge(ctx context.Context, db DBQuerier, mtreeTable, schema, ta
if err != nil {
return nil, fmt.Errorf("failed to render FindBlocksToMerge SQL: %w", err)
}
rows, err := db.Query(ctx, sql, queryArgs...)
rows, err := db.Query(ctx, sql, queryArgs...) // nosemgrep
if err != nil {
return nil, fmt.Errorf("query to find blocks to merge for '%s' failed: %w", mtreeTable, err)
}
Expand Down Expand Up @@ -2135,7 +2135,7 @@ func findBlocksToMerge(ctx context.Context, db DBQuerier, mtreeTable, schema, ta
if err != nil {
return nil, fmt.Errorf("failed to render FindBlocksToMergeExpanded SQL: %w", err)
}
rows, err := db.Query(ctx, sql, queryArgs...)
rows, err := db.Query(ctx, sql, queryArgs...) // nosemgrep
if err != nil {
return nil, fmt.Errorf("query to find blocks to merge for '%s' failed: %w", mtreeTable, err)
}
Expand Down Expand Up @@ -2416,7 +2416,7 @@ func GetBlockWithCount(ctx context.Context, db DBQuerier, mtreeTable, schema, ta
var count int64
var start, end any

row := db.QueryRow(ctx, query, position)
row := db.QueryRow(ctx, query, position) // nosemgrep, position is int64

if isComposite {
// node_position, start attrs..., end attrs..., count
Expand Down Expand Up @@ -2589,7 +2589,7 @@ func GetBulkSplitPoints(ctx context.Context, db DBQuerier, schema, table string,
return nil, fmt.Errorf("failed to render GetBulkSplitPoints SQL: %w", err)
}

rows, err := db.Query(ctx, query, args...)
rows, err := db.Query(ctx, query, args...) // nosemgrep
if err != nil {
return nil, fmt.Errorf("failed to execute bulk split points query: %w", err)
}
Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,10 @@ require (
go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace v0.63.0 // indirect
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.63.0 // indirect
go.opentelemetry.io/otel v1.43.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.38.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.43.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.43.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.43.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.38.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.43.0 // indirect
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.43.0 // indirect
go.opentelemetry.io/otel/metric v1.43.0 // indirect
go.opentelemetry.io/otel/sdk v1.43.0 // indirect
Expand Down
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,14 +546,14 @@ go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.63.0 h1:RbKq8BG
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.63.0/go.mod h1:h06DGIukJOevXaj/xrNjhi/2098RZzcLTbc0jDAUbsg=
go.opentelemetry.io/otel v1.43.0 h1:mYIM03dnh5zfN7HautFE4ieIig9amkNANT+xcVxAj9I=
go.opentelemetry.io/otel v1.43.0/go.mod h1:JuG+u74mvjvcm8vj8pI5XiHy1zDeoCS2LB1spIq7Ay0=
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.38.0 h1:vl9obrcoWVKp/lwl8tRE33853I8Xru9HFbw/skNeLs8=
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.38.0/go.mod h1:GAXRxmLJcVM3u22IjTg74zWBrRCKq8BnOqUVLodpcpw=
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.43.0 h1:8UQVDcZxOJLtX6gxtDt3vY2WTgvZqMQRzjsqiIHQdkc=
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.43.0/go.mod h1:2lmweYCiHYpEjQ/lSJBYhj9jP1zvCvQW4BqL9dnT7FQ=
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.43.0 h1:w1K+pCJoPpQifuVpsKamUdn9U0zM3xUziVOqsGksUrY=
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp v1.43.0/go.mod h1:HBy4BjzgVE8139ieRI75oXm3EcDN+6GhD88JT1Kjvxg=
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.43.0 h1:88Y4s2C8oTui1LGM6bTWkw0ICGcOLCAI5l6zsD1j20k=
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.43.0/go.mod h1:Vl1/iaggsuRlrHf/hfPJPvVag77kKyvrLeD10kpMl+A=
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.38.0 h1:lwI4Dc5leUqENgGuQImwLo4WnuXFPetmPpkLi2IrX54=
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.38.0/go.mod h1:Kz/oCE7z5wuyhPxsXDuaPteSWqjSBD5YaSdbxZYGbGk=
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.43.0 h1:RAE+JPfvEmvy+0LzyUA25/SGawPwIUbZ6u0Wug54sLc=
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.43.0/go.mod h1:AGmbycVGEsRx9mXMZ75CsOyhSP6MFIcj/6dnG+vhVjk=
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.43.0 h1:3iZJKlCZufyRzPzlQhUIWVmfltrXuGyfjREgGP3UUjc=
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.43.0/go.mod h1:/G+nUPfhq2e+qiXMGxMwumDrP5jtzU+mWN7/sjT2rak=
go.opentelemetry.io/otel/metric v1.43.0 h1:d7638QeInOnuwOONPp4JAOGfbCEpYb+K6DVWvdxGzgM=
Expand Down
20 changes: 11 additions & 9 deletions internal/consistency/diff/table_diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,10 @@ func (t *TableDiffTask) buildEffectiveFilter() (string, error) {
}

if t.resolvedAgainstOrigin != "" {
escaped := strings.ReplaceAll(t.resolvedAgainstOrigin, "'", "''")
parts = append(parts, fmt.Sprintf("(to_json(spock.xact_commit_timestamp_origin(xmin))->>'roident' = '%s')", escaped))
if _, err := strconv.Atoi(t.resolvedAgainstOrigin); err != nil {
return "", fmt.Errorf("resolved against-origin %q is not a valid numeric node ID", t.resolvedAgainstOrigin)
}
parts = append(parts, fmt.Sprintf("(to_json(spock.xact_commit_timestamp_origin(xmin))->>'roident' = '%s')", t.resolvedAgainstOrigin))
Comment on lines +255 to +258
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify parsed value is not currently reused and raw string is interpolated.
sed -n '248,262p' internal/consistency/diff/table_diff.go

Repository: pgEdge/ace

Length of output: 707

Normalize the validated origin ID before composing the predicate.

The code validates that t.resolvedAgainstOrigin is numeric with strconv.Atoi, but then discards the parsed value and interpolates the original string into the SQL fragment. This can create avoidable mismatches for equivalent numeric inputs like 01 vs 1.

Proposed fix 
-		if _, err := strconv.Atoi(t.resolvedAgainstOrigin); err != nil {
+		nodeID, err := strconv.Atoi(t.resolvedAgainstOrigin)
+		if err != nil {
 			return "", fmt.Errorf("resolved against-origin %q is not a valid numeric node ID", t.resolvedAgainstOrigin)
 		}
-		parts = append(parts, fmt.Sprintf("(to_json(spock.xact_commit_timestamp_origin(xmin))->>'roident' = '%s')", t.resolvedAgainstOrigin))
+		parts = append(parts, fmt.Sprintf("(to_json(spock.xact_commit_timestamp_origin(xmin))->>'roident' = '%d')", nodeID))
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@internal/consistency/diff/table_diff.go` around lines 255 - 258, The code
validates t.resolvedAgainstOrigin with strconv.Atoi but then interpolates the
original string, which can cause mismatches for equivalent numeric forms; change
the logic to parse and normalize the value (e.g. use strconv.Atoi or
strconv.ParseInt to get an integer) and use the normalized numeric string (via
strconv.Itoa or fmt.Sprintf("%d", parsed)) when building the SQL predicate in
the parts append call so the predicate uses the canonical numeric form of
t.resolvedAgainstOrigin.

}

if t.untilTime != nil {
Expand Down Expand Up @@ -333,7 +335,7 @@ func (t *TableDiffTask) estimateRowCount(pool *pgxpool.Pool, nodeName string) (i
}

var planJSON []byte
if err := pool.QueryRow(t.Ctx, query).Scan(&planJSON); err != nil {
if err := pool.QueryRow(t.Ctx, query).Scan(&planJSON); err != nil { // nosemgrep
return 0, fmt.Errorf("failed to estimate row count on node %s: %w", nodeName, err)
}

Expand All @@ -350,7 +352,7 @@ func (t *TableDiffTask) ensureFilterHasRows(pool *pgxpool.Pool, nodeName string)
sql := fmt.Sprintf("SELECT 1 FROM %s.%s WHERE %s LIMIT 1", schemaIdent, tableIdent, t.EffectiveFilter)

var one int
if err := pool.QueryRow(t.Ctx, sql).Scan(&one); err != nil {
if err := pool.QueryRow(t.Ctx, sql).Scan(&one); err != nil { // nosemgrep
if errors.Is(err, pgx.ErrNoRows) {
return fmt.Errorf("table filter produced no rows")
}
Expand Down Expand Up @@ -547,7 +549,7 @@ func (t *TableDiffTask) fetchRows(nodeName string, r Range) ([]types.OrderedMap,

logger.Debug("[%s] Fetching rows for range: Start=%v, End=%v. SQL: %s, Args: %v", nodeName, r.Start, r.End, querySQL, args)

pgRows, err := pool.Query(t.Ctx, querySQL, args...)
pgRows, err := pool.Query(t.Ctx, querySQL, args...) // nosemgrep
if err != nil {
return nil, fmt.Errorf("failed to query rows for range on node %s (SQL: %s, Args: %v): %w", nodeName, querySQL, args, err)
}
Expand Down Expand Up @@ -1015,7 +1017,7 @@ func (t *TableDiffTask) cleanupFilteredView() {
continue
}

if _, err := pool.Exec(t.Ctx, dropSQL); err != nil {
if _, err := pool.Exec(t.Ctx, dropSQL); err != nil { // nosemgrep
logger.Warn("table-diff: failed to drop filtered view %s.%s on node %s: %v", t.Schema, t.FilteredViewName, name, err)
} else {
logger.Info("table-diff: dropped filtered view %s.%s on node %s", t.Schema, t.FilteredViewName, name)
Expand Down Expand Up @@ -1819,7 +1821,7 @@ func (t *TableDiffTask) generateSubRanges(

countQuery := fmt.Sprintf("SELECT COUNT(1) FROM %s %s", schemaTable, whereClause)
var count int64
err := pool.QueryRow(t.Ctx, countQuery, args...).Scan(&count)
err := pool.QueryRow(t.Ctx, countQuery, args...).Scan(&count) // nosemgrep
if err != nil {
logger.Debug("[%s] Failed to count rows in parent range %v-%v for splitting: %v. SQL: %s, Args: %v", node, parentRange.Start, parentRange.End, err, countQuery, args)
return nil, fmt.Errorf("failed to count for split: %w", err)
Expand Down Expand Up @@ -1849,14 +1851,14 @@ func (t *TableDiffTask) generateSubRanges(
numPKCols := len(t.Key)

if numPKCols == 1 {
err = pool.QueryRow(t.Ctx, medianQuery, medianQueryArgs...).Scan(&medianPKVal)
err = pool.QueryRow(t.Ctx, medianQuery, medianQueryArgs...).Scan(&medianPKVal) // nosemgrep
} else {
scanDest := make([]any, numPKCols)
scanDestPtrs := make([]any, numPKCols)
for i := range scanDest {
scanDestPtrs[i] = &scanDest[i]
}
err = pool.QueryRow(t.Ctx, medianQuery, medianQueryArgs...).Scan(scanDestPtrs...)
err = pool.QueryRow(t.Ctx, medianQuery, medianQueryArgs...).Scan(scanDestPtrs...) // nosemgrep
if err == nil {
medianPKVal = append([]any{}, scanDest...)
}
Expand Down
4 changes: 2 additions & 2 deletions internal/consistency/diff/table_rerun.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ func fetchRowsByPkeys(ctx context.Context, pool *pgxpool.Pool, t *TableDiffTask,

createTempTableSQL := fmt.Sprintf("CREATE TEMPORARY TABLE %s (%s) ON COMMIT PRESERVE ROWS", sanitisedTempTable, strings.Join(pkColDefs, ", "))
logger.Debug("Creating temporary table for pkeys: %s", createTempTableSQL)
_, err = tx.Exec(ctx, createTempTableSQL)
_, err = tx.Exec(ctx, createTempTableSQL) // nosemgrep
if err != nil {
return nil, fmt.Errorf("failed to create temporary table: %w", err)
}
Expand Down Expand Up @@ -286,7 +286,7 @@ func fetchRowsByPkeys(ctx context.Context, pool *pgxpool.Pool, t *TableDiffTask,
strings.Join(selectCols, ", "), schemaTable, sanitisedTempTable, strings.Join(joinConditions, " AND "))

logger.Debug("Fetching rows with pkeys from temporary table: %s", fetchSQL)
pgRows, err := tx.Query(ctx, fetchSQL)
pgRows, err := tx.Query(ctx, fetchSQL) // nosemgrep
if err != nil {
return nil, fmt.Errorf("failed to query rows using temp table join: %w", err)
}
Expand Down
Loading