feat: provision per-host Postgres user for RAG service instances #299
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,229 @@ | ||
| package swarm | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/pgEdge/control-plane/server/internal/database" | ||
| "github.com/pgEdge/control-plane/server/internal/resource" | ||
| ) | ||
|
|
||
| func TestGenerateRAGInstanceResources_ResourceList(t *testing.T) { | ||
| o := &Orchestrator{} | ||
| spec := &database.ServiceInstanceSpec{ | ||
| ServiceInstanceID: "storefront-rag-host1", | ||
| ServiceSpec: &database.ServiceSpec{ | ||
| ServiceID: "rag", | ||
| ServiceType: "rag", | ||
| Version: "latest", | ||
| }, | ||
| DatabaseID: "storefront", | ||
| DatabaseName: "storefront", | ||
| HostID: "host-1", | ||
| NodeName: "n1", | ||
| } | ||
|
|
||
| result, err := o.generateRAGInstanceResources(spec) | ||
| if err != nil { | ||
| t.Fatalf("generateRAGInstanceResources() error = %v", err) | ||
| } | ||
|
|
||
| if result.ServiceInstance == nil { | ||
| t.Fatal("ServiceInstance is nil") | ||
| } | ||
| if result.ServiceInstance.ServiceInstanceID != spec.ServiceInstanceID { | ||
| t.Errorf("ServiceInstance.ServiceInstanceID = %q, want %q", | ||
| result.ServiceInstance.ServiceInstanceID, spec.ServiceInstanceID) | ||
| } | ||
| if result.ServiceInstance.HostID != spec.HostID { | ||
| t.Errorf("ServiceInstance.HostID = %q, want %q", | ||
| result.ServiceInstance.HostID, spec.HostID) | ||
| } | ||
| if result.ServiceInstance.State != database.ServiceInstanceStateCreating { | ||
| t.Errorf("ServiceInstance.State = %q, want %q", | ||
| result.ServiceInstance.State, database.ServiceInstanceStateCreating) | ||
| } | ||
|
|
||
| // Single node: one canonical RO ServiceUserRole. | ||
| if len(result.Resources) != 1 { | ||
| t.Fatalf("len(Resources) = %d, want 1", len(result.Resources)) | ||
| } | ||
| if result.Resources[0].Identifier.Type != ResourceTypeServiceUserRole { | ||
| t.Errorf("Resources[0].Identifier.Type = %q, want %q", | ||
| result.Resources[0].Identifier.Type, ResourceTypeServiceUserRole) | ||
| } | ||
| wantID := ServiceUserRoleIdentifier("rag", ServiceUserRoleRO) | ||
| if result.Resources[0].Identifier != wantID { | ||
| t.Errorf("Resources[0].Identifier = %v, want %v", result.Resources[0].Identifier, wantID) | ||
| } | ||
| } | ||
|
|
||
| func TestGenerateRAGInstanceResources_MultiNode(t *testing.T) { | ||
| o := &Orchestrator{} | ||
| spec := &database.ServiceInstanceSpec{ | ||
| ServiceInstanceID: "storefront-rag-host1", | ||
| ServiceSpec: &database.ServiceSpec{ | ||
| ServiceID: "rag", | ||
| ServiceType: "rag", | ||
| Version: "latest", | ||
| }, | ||
| DatabaseID: "storefront", | ||
| DatabaseName: "storefront", | ||
| HostID: "host-1", | ||
| NodeName: "n1", | ||
| DatabaseNodes: []*database.NodeInstances{ | ||
| {NodeName: "n1"}, | ||
| {NodeName: "n2"}, | ||
| {NodeName: "n3"}, | ||
| }, | ||
| } | ||
|
|
||
| result, err := o.generateRAGInstanceResources(spec) | ||
| if err != nil { | ||
| t.Fatalf("generateRAGInstanceResources() error = %v", err) | ||
| } | ||
|
|
||
| // 3 nodes → canonical(n1) + per-node(n2) + per-node(n3) = 3 RO resources | ||
| if len(result.Resources) != 3 { | ||
| t.Fatalf("len(Resources) = %d, want 3", len(result.Resources)) | ||
| } | ||
| for _, rd := range result.Resources { | ||
| if rd.Identifier.Type != ResourceTypeServiceUserRole { | ||
| t.Errorf("resource type = %q, want %q", rd.Identifier.Type, ResourceTypeServiceUserRole) | ||
| } | ||
| } | ||
|
|
||
| // Canonical is first and has no CredentialSource | ||
| canonical, err := resource.ToResource[*ServiceUserRole](result.Resources[0]) | ||
| if err != nil { | ||
| t.Fatalf("ToResource canonical: %v", err) | ||
| } | ||
| if canonical.CredentialSource != nil { | ||
| t.Errorf("canonical resource should have nil CredentialSource, got %v", canonical.CredentialSource) | ||
| } | ||
| if canonical.Mode != ServiceUserRoleRO { | ||
| t.Errorf("canonical Mode = %q, want %q", canonical.Mode, ServiceUserRoleRO) | ||
| } | ||
|
|
||
| // Per-node resources point back to canonical | ||
| canonicalID := ServiceUserRoleIdentifier("rag", ServiceUserRoleRO) | ||
| for i, rd := range result.Resources[1:] { | ||
| perNode, err := resource.ToResource[*ServiceUserRole](rd) | ||
| if err != nil { | ||
| t.Fatalf("ToResource per-node[%d]: %v", i, err) | ||
| } | ||
| if perNode.CredentialSource == nil || *perNode.CredentialSource != canonicalID { | ||
| t.Errorf("per-node[%d].CredentialSource = %v, want %v", i, perNode.CredentialSource, canonicalID) | ||
| } | ||
| if perNode.Mode != ServiceUserRoleRO { | ||
| t.Errorf("per-node[%d].Mode = %q, want %q", i, perNode.Mode, ServiceUserRoleRO) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestGenerateRAGInstanceResources_MultiNode_CanonicalNotFirst(t *testing.T) { | ||
| o := &Orchestrator{} | ||
| spec := &database.ServiceInstanceSpec{ | ||
| ServiceInstanceID: "storefront-rag-host2", | ||
| ServiceSpec: &database.ServiceSpec{ | ||
| ServiceID: "rag", | ||
| ServiceType: "rag", | ||
| Version: "latest", | ||
| }, | ||
| DatabaseID: "storefront", | ||
| DatabaseName: "storefront", | ||
| HostID: "host-2", | ||
| NodeName: "n2", // canonical is n2, not at index 0 | ||
| DatabaseNodes: []*database.NodeInstances{ | ||
| {NodeName: "n1"}, | ||
| {NodeName: "n2"}, | ||
| {NodeName: "n3"}, | ||
| }, | ||
| } | ||
|
|
||
| result, err := o.generateRAGInstanceResources(spec) | ||
| if err != nil { | ||
| t.Fatalf("generateRAGInstanceResources() error = %v", err) | ||
| } | ||
|
|
||
| // 3 nodes → canonical(n2) + per-node(n1) + per-node(n3) = 3 RO resources | ||
| if len(result.Resources) != 3 { | ||
| t.Fatalf("len(Resources) = %d, want 3", len(result.Resources)) | ||
| } | ||
|
|
||
| // Canonical (index 0) must be n2 with no CredentialSource | ||
| canonical, err := resource.ToResource[*ServiceUserRole](result.Resources[0]) | ||
| if err != nil { | ||
| t.Fatalf("ToResource canonical: %v", err) | ||
| } | ||
| if canonical.CredentialSource != nil { | ||
| t.Errorf("canonical resource should have nil CredentialSource, got %v", canonical.CredentialSource) | ||
| } | ||
| if canonical.NodeName != "n2" { | ||
| t.Errorf("canonical NodeName = %q, want %q", canonical.NodeName, "n2") | ||
| } | ||
|
|
||
| // Per-node resources must cover n1 and n3, not n2 | ||
| canonicalID := ServiceUserRoleIdentifier("rag", ServiceUserRoleRO) | ||
| perNodeNames := make(map[string]bool) | ||
| for i, rd := range result.Resources[1:] { | ||
| perNode, err := resource.ToResource[*ServiceUserRole](rd) | ||
| if err != nil { | ||
| t.Fatalf("ToResource per-node[%d]: %v", i, err) | ||
| } | ||
| if perNode.CredentialSource == nil || *perNode.CredentialSource != canonicalID { | ||
| t.Errorf("per-node[%d].CredentialSource = %v, want %v", i, perNode.CredentialSource, canonicalID) | ||
| } | ||
| perNodeNames[perNode.NodeName] = true | ||
| } | ||
| if perNodeNames["n2"] { | ||
| t.Error("canonical node n2 must not appear in per-node resources") | ||
| } | ||
| if !perNodeNames["n1"] || !perNodeNames["n3"] { | ||
| t.Errorf("per-node resources = %v, want n1 and n3", perNodeNames) | ||
| } | ||
| } | ||
|
|
||
| func TestGenerateServiceInstanceResources_RAGDispatch(t *testing.T) { | ||
| o := &Orchestrator{} | ||
| spec := &database.ServiceInstanceSpec{ | ||
| ServiceInstanceID: "db1-rag-host1", | ||
| ServiceSpec: &database.ServiceSpec{ | ||
| ServiceID: "rag", | ||
| ServiceType: "rag", | ||
| Version: "latest", | ||
| }, | ||
| DatabaseID: "db1", | ||
| DatabaseName: "db1", | ||
| HostID: "host-1", | ||
| NodeName: "n1", | ||
| } | ||
|
|
||
| result, err := o.GenerateServiceInstanceResources(spec) | ||
| if err != nil { | ||
| t.Fatalf("GenerateServiceInstanceResources() error = %v", err) | ||
| } | ||
| if result == nil { | ||
| t.Fatal("result is nil") | ||
| } | ||
| } | ||
|
|
||
| func TestGenerateServiceInstanceResources_UnknownTypeReturnsError(t *testing.T) { | ||
| o := &Orchestrator{} | ||
| spec := &database.ServiceInstanceSpec{ | ||
| ServiceInstanceID: "db1-unknown-host1", | ||
| ServiceSpec: &database.ServiceSpec{ | ||
| ServiceID: "unknown", | ||
| ServiceType: "unknown", | ||
| Version: "latest", | ||
| }, | ||
| DatabaseID: "db1", | ||
| DatabaseName: "db1", | ||
| HostID: "host-1", | ||
| NodeName: "n1", | ||
| } | ||
|
|
||
| _, err := o.GenerateServiceInstanceResources(spec) | ||
| if err == nil { | ||
| t.Fatal("expected error for unknown service type, got nil") | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.