Add toast_tuple_target to Materialized View properties dialog (#9626)#9769
Draft
pavanmanishd wants to merge 1 commit intopgadmin-org:masterfrom
Draft
Add toast_tuple_target to Materialized View properties dialog (#9626)#9769pavanmanishd wants to merge 1 commit intopgadmin-org:masterfrom
pavanmanishd wants to merge 1 commit intopgadmin-org:masterfrom
Conversation
…ties properties.sql: extract toast_tuple_target from c.reloptions create.sql: include TOAST_TUPLE_TARGET in WITH clause when set update.sql: SET/RESET TOAST_TUPLE_TARGET when value changes mview.ui.js: add int field (128-8160, PG11+) in Definition group Mirrors the existing fillfactor pattern throughout.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9626
Problem
The
toast_tuple_targetstorage parameter (PostgreSQL 11+) is supported by materialized views viaALTER MATERIALIZED VIEW ... SET(TOAST_TUPLE_TARGET = N), but the pgAdmin Materialized View properties dialog has no way to view or change it.Changes
toast_tuple_targetfromc.reloptions(same regex pattern asfillfactor)TOAST_TUPLE_TARGETin theWITHclause when set; extend the condition that decides whether aWITHblock is neededSET/RESETTOAST_TUPLE_TARGETwhen the value changes (mirrors theFILLFACTORblock exactly)min_version: 110000