Docs: Text#setResolution() description#7266
Open
samme wants to merge 1 commit intophaserjs:v4.0.0from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
I think the original description is now obsolete and has caused some user confusion.
Note
Low Risk
Documentation-only change to
Text#setResolutionJSDoc; no runtime behavior is modified, so risk is minimal aside from potential wording/expectation shifts.Overview
Updates the
Text#setResolutionJSDoc to clarify that it controls the texture resolution, is only beneficial when the Text (or an ancestor/camera) is scaled up, and that the value is relative to1.Rewords the memory-use warning to emphasize the cost of higher-resolution text textures.
Written by Cursor Bugbot for commit c83a0e8. This will update automatically on new commits. Configure here.