Add IME fallback and blocked exclusion keys#4868
Open
tygakim wants to merge 1 commit intophilc:masterfrom
Open
Add IME fallback and blocked exclusion keys#4868tygakim wants to merge 1 commit intophilc:masterfrom
tygakim wants to merge 1 commit intophilc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds two features to improve Vimium's keyboard handling:
Non-Latin IME support: When a non-Latin IME is active (Korean, Japanese, etc.), Vimium automatically falls back to
event.code(physical key position) so commands work regardless of active input method, while preserving Latin layouts like French.Blocked keys in exclusion rules: Adds a
blockedKeysfield — the inverse ofpassKeys. Suppresses specified keys so the website never receives them, allowing users to block conflicting website shortcuts (e.g. YouTube'sf) per-site.Please review the "Which pull requests get merged?" section in
CONTRIBUTING.md.