[feature] New tab indicator in omni bar#4881
Open
ckardaris wants to merge 1 commit intophilc:masterfrom
Open
Conversation
- Add omni bar mode indicator to the left of the input field. - Add new tab indicator '+' if the omni bar action will be completed in a new tab. - Provide shortcut (alt + n) to switch between current tab and new tab mode. - Provide shortcut (alt + m / alt + M) to cycle over the available omni bar completers.
ckardaris
force-pushed
the
vimium-4509-different-tab-completion-style
branch
from
cad44fd to
143709c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a new tab.
mode.
bar completers.
Description
Good evening. This MR is a POC related to #4509.
The proposed design changes may be deemed too radical, but I am submitting them here for discussion.
Change no. 1
The omni bar "mode" is shown to the left of the input field. Shortcuts
Alt + m/Mare used to cycle through modes (the input text is preserved). This can be useful if you realize you need to search in another mode and don't want to lose text input or pressEsc+<correct shortcut>.Change no. 2
A plus sign
+is added next to the name of the mode if the selected action will be opened in a new tab (not counting with any modifier shortcuts likeShift + Enter. The shortcutAlt + nis used to switch this current tab / new tab mode.