Disallow partial uses in ReferenceUsedNamesOnly#57
Merged
dereuromark merged 1 commit intomasterfrom Apr 11, 2026
Merged
Conversation
Partial namespace references like Mockery\MockInterface were not being flagged because Slevomat's allowPartialUses defaults to true. Set it to false so such references must be imported via a use statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial namespace references like
Mockery\MockInterface(as opposed to FQCN\Mockery\MockInterface) were not flagged bySlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnlybecause Slevomat'sallowPartialUsesproperty defaults totrue. Setting it tofalsemakes the sniff flag such references so they must be imported via ausestatement.Related: cakephp/cakephp-codesniffer#430 — same bug confirmed in this ruleset.
Before
After
The FQCN form (
\Mockery\MockInterface) was and remains flagged by the same sniff viaReferenceViaFullyQualifiedName.Note: this is a behavior-tightening change. Downstream code that intentionally uses partial imports (e.g.
use Doctrine\ORM\Mapping as ORM;+ORM\Entity) will now error.