Skip to content

Fix HtmlToDjot inline quote escaping#169

Merged
dereuromark merged 3 commits intomasterfrom
feature/fix-html-to-djot-inline-quotes
Apr 1, 2026
Merged

Fix HtmlToDjot inline quote escaping#169
dereuromark merged 3 commits intomasterfrom
feature/fix-html-to-djot-inline-quotes

Conversation

@dereuromark
Copy link
Copy Markdown
Contributor

Summary

  • escape backslashes and double quotes inside HtmlToDjot inline quote conversion so content stays valid Djot
  • fix both plain quotes and cited quotes generated from ...
  • add converter regressions that verify the generated Djot reparses back to HTML containing the original quoted text

Verification

  • vendor/bin/phpunit tests/TestCase/Converter/HtmlToDjotTest.php
  • vendor/bin/phpunit tests/TestCase/Converter/HtmlToDjotTest.php tests/TestCase/RoundTripTest.php tests/TestCase/DjotConverterTest.php
  • vendor/bin/phpstan analyse src --no-progress
  • vendor/bin/phpunit

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.98%. Comparing base (3a5c7f6) to head (229e718).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #169   +/-   ##
=========================================
  Coverage     93.97%   93.98%           
- Complexity     3133     3135    +2     
=========================================
  Files            93       93           
  Lines          8006     8009    +3     
=========================================
+ Hits           7524     7527    +3     
  Misses          482      482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dereuromark dereuromark merged commit 345a47b into master Apr 1, 2026
6 checks passed
@dereuromark dereuromark deleted the feature/fix-html-to-djot-inline-quotes branch April 1, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant