Skip to content

Fix SemanticSpanExtension samp and var rendering#170

Merged
dereuromark merged 1 commit intomasterfrom
feature/fix-semantic-span-samp-var
Apr 1, 2026
Merged

Fix SemanticSpanExtension samp and var rendering#170
dereuromark merged 1 commit intomasterfrom
feature/fix-semantic-span-samp-var

Conversation

@dereuromark
Copy link
Copy Markdown
Contributor

Summary

  • render samp and var semantic span attributes as <samp> and <var>
  • remove those processed attributes from the outer span before rendering
  • add extension regression coverage for standalone and combined samp/var

Testing

  • vendor/bin/phpunit tests/TestCase/Extension/SemanticSpanExtensionTest.php tests/TestCase/Converter/HtmlToDjotTest.php
  • vendor/bin/phpstan analyse src --no-progress
  • vendor/bin/phpunit

@dereuromark dereuromark merged commit 6b165b4 into master Apr 1, 2026
4 checks passed
@dereuromark dereuromark deleted the feature/fix-semantic-span-samp-var branch April 1, 2026 20:51
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.98%. Comparing base (345a47b) to head (8a3e5e6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #170   +/-   ##
=========================================
  Coverage     93.98%   93.98%           
- Complexity     3135     3139    +4     
=========================================
  Files            93       93           
  Lines          8009     8017    +8     
=========================================
+ Hits           7527     7535    +8     
  Misses          482      482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant