Skip to content

Fix HtmlToDjot container and list block serialization#173

Merged
dereuromark merged 3 commits intomasterfrom
feature/fix-html-to-djot-container-and-list-blocks
Apr 1, 2026
Merged

Fix HtmlToDjot container and list block serialization#173
dereuromark merged 3 commits intomasterfrom
feature/fix-html-to-djot-container-and-list-blocks

Conversation

@dereuromark
Copy link
Copy Markdown
Contributor

Summary

  • preserve generic HTML5 container attributes and details boundaries as tagged fenced divs instead of dropping them
  • serialize list items with multiple block children using proper blank-line and continuation indentation
  • add converter regressions for details, attributed HTML5 containers, multi-paragraph list items, nested blockquotes, and code blocks in list items

Testing

  • vendor/bin/phpunit tests/TestCase/Converter/HtmlToDjotTest.php
  • vendor/bin/phpunit tests/TestCase/Converter/HtmlToDjotTest.php tests/TestCase/RoundTripTest.php tests/TestCase/DjotConverterTest.php tests/TestCase/ProfileTest.php
  • vendor/bin/phpstan analyse src --no-progress
  • vendor/bin/phpunit

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 92.42424% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.66%. Comparing base (16db29a) to head (7ab7de6).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Converter/HtmlToDjot.php 92.42% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #173      +/-   ##
============================================
+ Coverage     93.62%   93.66%   +0.03%     
- Complexity     3175     3201      +26     
============================================
  Files            93       93              
  Lines          8076     8125      +49     
============================================
+ Hits           7561     7610      +49     
  Misses          515      515              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dereuromark dereuromark merged commit 59a5e5f into master Apr 1, 2026
5 of 6 checks passed
@dereuromark dereuromark deleted the feature/fix-html-to-djot-container-and-list-blocks branch April 1, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant