ext/posix: validate mode argument in posix_access #21104
+72
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Jan 31, 2026
devnexen
reviewed
Jan 31, 2026
devnexen
reviewed
Feb 1, 2026
| echo "File exists OK\n"; | ||
| } | ||
|
|
||
| unlink($testfile); |
Member
There was a problem hiding this comment.
usually more appropriate to put such operations in a CLEAN section.
Member
There was a problem hiding this comment.
also $testfile is very probably undefined at this stage.
devnexen
reviewed
Feb 1, 2026
| unlink($testfile); | ||
| $dir = __DIR__; | ||
| $testfile = "$dir/testfile.txt"; | ||
| if (file_exists($testfile)) { |
Member
There was a problem hiding this comment.
you can probably simplify with just @unlink($testfile);
note: no need to rush committing after every comment ;) kind of burden the CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper validation for the
flagargument inposix_access().