Skip to content

Fix Laravel build for PHP 8.2 #21473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iluuu1994 wants to merge 2 commits into from
Closed

Fix Laravel build for PHP 8.2 #21473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
183d2a6
Fix Laravel build for PHP 8.2
iluuu1994 Mar 20, 2026
272cf1f
Use default branch for symfony/laravel when possible
iluuu1994 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/matrix.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,14 @@ function select_jobs($repository, $trigger, $nightly, $labels, $php_version, $re
$jobs['COMMUNITY']['matrix'] = version_compare($php_version, '8.4', '>=')
? ['type' => ['asan', 'verify_type_inference']]
: ['type' => ['asan']];
$jobs['COMMUNITY']['config']['symfony_version'] = version_compare($php_version, '8.4', '>=') ? '8.1' : '7.4';
$jobs['COMMUNITY']['config']['symfony_version'] = match (true) {
version_compare($php_version, '8.3', '<=') => '7.4',
default => '',
};
$jobs['COMMUNITY']['config']['laravel_version'] = match (true) {
version_compare($php_version, '8.2', '<=') => '12.x',
default => '',
};
}
if (($all_jobs && $ref === 'master') || $test_coverage) {
$jobs['COVERAGE'] = true;
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/test-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,8 @@ jobs:
- name: Test Laravel
if: ${{ !cancelled() }}
run: |
git clone https://github.com/laravel/framework.git --depth=1
branch=${{ fromJson(inputs.branch).jobs.COMMUNITY.config.laravel_version }}
git clone https://github.com/laravel/framework.git --depth=1 ${branch:+--branch="$branch"}
cd framework
git rev-parse HEAD
php /usr/bin/composer install --no-progress --ignore-platform-req=php+
Expand Down Expand Up @@ -551,7 +552,8 @@ jobs:
- name: Test Symfony
if: ${{ !cancelled() }}
run: |
git clone https://github.com/symfony/symfony.git --depth=1 --branch="${{ fromJson(inputs.branch).jobs.COMMUNITY.config.symfony_version }}"
branch=${{ fromJson(inputs.branch).jobs.COMMUNITY.config.symfony_version }}
git clone https://github.com/symfony/symfony.git --depth=1 ${branch:+--branch="$branch"}
cd symfony
git rev-parse HEAD
php /usr/bin/composer install --no-progress --ignore-platform-req=php+
Expand Down
Loading