Skip to content

Optimize JSON pretty print indentation performance #21474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LamentXU123 wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −2
Open

Optimize JSON pretty print indentation performance #21474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d40408
Update json_encoder.c
LamentXU123 Mar 20, 2026
a967ff1
Update UPGRADING
LamentXU123 Mar 20, 2026
9ac40b5
apply changes from reviews
LamentXU123 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UPGRADING
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,8 @@ PHP 8.6 UPGRADE NOTES

- JSON:
. Improve performance of encoding arrays and objects.
. Improved performance of indentation generation in json_encode()
when using PHP_JSON_PRETTY_PRINT.

- Standard:
. Improved performance of array_fill_keys().
Expand Down
6 changes: 4 additions & 2 deletions ext/json/json_encoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@ static inline void php_json_pretty_print_char(smart_str *buf, int options, char
static inline void php_json_pretty_print_indent(smart_str *buf, int options, const php_json_encoder *encoder) /* {{{ */
{
if (options & PHP_JSON_PRETTY_PRINT) {
for (int i = 0; i < encoder->depth; ++i) {
smart_str_appendl(buf, " ", 4);
size_t remaining = (size_t) encoder->depth * 4;
if (remaining) {
char *dst = smart_str_extend(buf, remaining);
memset(dst, ' ', remaining);
}
}
}
Expand Down
Loading