zend_vm_gen.php: Make room for new zend_vm_opcodes_flags flags#21476
Open
arnaud-lb wants to merge 1 commit intophp:masterfrom
Open
zend_vm_gen.php: Make room for new zend_vm_opcodes_flags flags#21476arnaud-lb wants to merge 1 commit intophp:masterfrom
zend_vm_opcodes_flags flags#21476arnaud-lb wants to merge 1 commit intophp:masterfrom
Conversation
github-actions
bot
added
Category: Engine
Extension: opcache
Category: Optimizer
ABI break
labels
Split OP flags and EXT flags in two separate sets, in zend_vm_gen.php to maintain 32bit support. In Zend/zend_vm_opcodes.c we can unify them again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make room for new
zend_vm_opcodes_flagsflags.I needed several times to add new
ZEND_VM_OP_orZEND_VM_EXT_flags, but there is no room left. Here I make some room to facilitate future experiments that may need new flags.Essentially I'm promoting
zend_get_opcode_flags()to auint64_t. Inzend_vm_gen.phpI split the OP and EXT flags in two separate sets to maintain 32bit support. InZend/zend_vm_opcodes.cwe can unify them again.