Merged
Conversation
Added to investigate dependency issues in the project. The analyser found: shadow dependency on symfony/process, potentially unused symfony/event-dispatcher, and a known phpunit usage in production code. https://claude.ai/code/session_012FSwcnH3TTTEbhmNdj1L38
- Remove unused symfony/event-dispatcher from require - Add symfony/process to require-dev (was a shadow dependency used in E2E tests) https://claude.ai/code/session_012FSwcnH3TTTEbhmNdj1L38
No longer needed after fixing the dependency issues it identified. https://claude.ai/code/session_012FSwcnH3TTTEbhmNdj1L38
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
=========================================
Coverage 97.90% 97.90%
Complexity 664 664
=========================================
Files 84 84
Lines 1912 1912
=========================================
Hits 1872 1872
Misses 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
shipmonk/composer-dependency-analyserwe identified and fixed two dependency issues:symfony/event-dispatcherfromrequire: no usage was found anywhere in the source codesymfony/processtorequire-dev: it was used in E2E tests (RunArkitectBinTest) but not declared as a dependency (shadow dependency)