Report invalid printf placeholder

[VincentLanglet]

Closes phpstan/phpstan#1889
Closes phpstan/phpstan#8547 (cc @staabm)

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

Would be nice to know what the invalid placeholder is and its position. Otherwise it'd be hard to debug with long format strings as %c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%c%.

[VincentLanglet]

I thought about this and I was wondering if we should iterate and add more details with acceptsReasonsTip later because:

• This would require some weird signature for getPrintfPlaceholdersCount (Returning the count + the invalid placeholders/positions)

• This would require to handle error message for

  • Union string %c%|%c%c% => What would be the message ? 3rd position ? 5th position ?
  • String with multiple wrong placeholder like %%% %%% => Should we report all the invalid ones ?

=> maybe you already have an idea about the format of the message @ondrejmirtes ?

[ondrejmirtes]

Also maybe this belongs to bleeding edge only?

[VincentLanglet]

Also maybe this belongs to bleeding edge only?

I would have consider this kinda as a "bugfix".
Technically the sprintf('%') call should have been reported since there is was missing parameter https://3v4l.org/lAIAAs

I can put this behind bleeding edge, but that would mean adding an extra parameters to getPrintfPlaceholdersCount methods with something like getPrintfPlaceholdersCount($format, $reportInvalidPlaceholder). It's your call !