Skip to content

move info from docker readme to the docs#1321

Merged
PromoFaux merged 3 commits intomasterfrom
dockerdocs
Mar 18, 2026
Merged

move info from docker readme to the docs#1321
PromoFaux merged 3 commits intomasterfrom
dockerdocs

Conversation

@PromoFaux
Copy link
Copy Markdown
Member

@PromoFaux PromoFaux commented Nov 27, 2025

What does this PR aim to accomplish?:

Trying to tidy up the docker readme a bit because it is getting unwieldy...

pi-hole/docker-pi-hole#1958

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from a team as a code owner November 27, 2025 21:31
Comment thread docs/docker/configuration.md Outdated
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 27, 2025

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit d8ee7f5
🔍 Latest deploy log https://app.netlify.com/projects/pihole-docs/deploys/69b9a19d541fa20008cadbed
😎 Deploy Preview https://deploy-preview-1321--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rdwebdesign

This comment was marked as outdated.

@PromoFaux

This comment was marked as outdated.

@rdwebdesign
Copy link
Copy Markdown
Member

Well spotted, I, err, was testing anyone actually reads things before they review. ;)

😕 😒

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
Comment thread docs/docker/index.md
…instead

Tweak tags section

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@rdwebdesign
Copy link
Copy Markdown
Member

I think both PRs (this one and docker #1958) are good to go, but this branch needs to be updated.

@PromoFaux PromoFaux requested a review from rdwebdesign March 17, 2026 18:47
@PromoFaux
Copy link
Copy Markdown
Member Author

@rdwebdesign I've re-requested a review as it says you requested changes (though think they are no longer needed...)

@PromoFaux PromoFaux merged commit bb2fc3e into master Mar 18, 2026
13 checks passed
@PromoFaux PromoFaux deleted the dockerdocs branch March 18, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants