Skip to content

fix(ci): correct deploy input string comparison#440

Merged
bishoy-at-pieces merged 1 commit intomainfrom
fix-input-deployment
Feb 23, 2026
Merged

fix(ci): correct deploy input string comparison#440
bishoy-at-pieces merged 1 commit intomainfrom
fix-input-deployment

Conversation

@bishoy-at-pieces
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the GitHub Actions workflow where a boolean input was incorrectly compared to a string literal. The deploy input is defined as type: boolean but was being compared to the string 'true' instead of the boolean value true.

Changes:

  • Corrected the comparison of inputs.deploy from 'true' (string) to true (boolean) on line 316

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@nolan-at-pieces nolan-at-pieces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bishoy-at-pieces bishoy-at-pieces merged commit bfa55be into main Feb 23, 2026
14 checks passed
@bishoy-at-pieces bishoy-at-pieces deleted the fix-input-deployment branch February 23, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Python 3.14

3 participants