fix(migrations): sync Migration indexes on boot to enforce unique name

[PierreBrisorgueil]

Summary

• What changed: Call Migration.syncIndexes() at the start of migrations.run() so the unique-on-name index is created/re-created before any read or write against the migrations collection. Add a unit test asserting the schema declares unique: true on name.
• Why: The Migration schema has unique: true on name, but the index is only built when Mongoose auto-creates it. Deployments whose migrations collection was created before the unique flag was added kept running without the index, silently allowing duplicate claims and causing the should reject duplicate migration names integration test to fail on clean boots. This also breaks the atomic claim guarantee used by claimMigration() to prevent concurrent runners from executing the same migration twice.
• Related issues: Closes fix(migrations): duplicate name test fails — unique index missing #3454

Scope

• Module(s) impacted: lib/services/migrations.js, modules/core/tests/migrations.unit.tests.js
• Cross-module impact: none
• Risk level: low

Validation

• npm run lint
• npm test (full suite with coverage — 766 tests, 64 suites, all green)
• Manual checks done — reproduced the failing test on master, confirmed green after the fix, re-ran integration tests 3x to confirm stability

Guardrails check

• No secrets or credentials introduced
• No risky rename/move of core stack paths
• Changes remain merge-friendly for downstream projects
• Tests added or updated when behavior changed

Notes for reviewers

• Security considerations: The unique index backs the atomic claim logic in claimMigration() that prevents two concurrent boot runners (e.g. rolling deploys) from executing the same migration twice. Without the index the claim is not actually atomic — this fix closes that gap for collections that pre-date the unique: true declaration.
• Mergeability considerations: syncIndexes() is idempotent and cheap; it runs once per boot in migrations.run() before any claimMigration() / recordMigration() call, so there's no race. Safe on fresh collections (creates the index) and safe on collections that already have it (no-op).
• Follow-up tasks (optional): none.

Summary by CodeRabbit

• Chores

  • Migration system now synchronizes database indexes with schema on startup to ensure consistency.

• Tests

  • Added test coverage verifying migration name field index configuration.

[coderabbitai]

Warning

Rate limit exceeded

@PierreBrisorgueil has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 21 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 22 minutes and 21 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 31cd9fe5-3326-4879-b99d-29cfc3b68560

📥 Commits

Reviewing files that changed from the base of the PR and between bcb28c0 and de6c666.

📒 Files selected for processing (2)

• lib/services/migrations.js
• modules/core/repositories/migration.repository.js

Walkthrough

Added a new ensureMigrationIndexes() helper function to the migrations service that synchronizes the Migration model's collection indexes with its schema definition. This function is called during the migration initialization flow to ensure the unique name index exists before any migration operations occur.

Changes

Cohort / File(s)	Summary
Migration Service Enhancement lib/services/migrations.js	Added ensureMigrationIndexes() async helper that invokes Migration.syncIndexes() to reconcile collection indexes with schema. Integrated into the run() flow immediately after model registration and before migration discovery/execution. Extended default export to include the new function.
Migration Model Validation modules/core/tests/migrations.unit.tests.js	Added unit test to verify the name field schema path includes unique: true index option, confirming the unique constraint is properly configured on the Migration model.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: calling Migration.syncIndexes() on boot to enforce the unique name index.
Description check	✅ Passed	The PR description is comprehensive and follows the template with all required sections: summary, scope, validation, guardrails check, and notes for reviewers.
Linked Issues check	✅ Passed	The PR fully addresses issue #3454 by ensuring the unique index on the name field is enforced via syncIndexes() at boot before any migration operations.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the unique index enforcement issue: adding ensureMigrationIndexes() to migrations.js and a schema validation test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/3454-migrations-unique-index

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.81%. Comparing base (67acceb) to head (de6c666).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3455      +/-   ##
==========================================
+ Coverage   85.74%   85.81%   +0.06%     
==========================================
  Files         114      115       +1     
  Lines        2911     2911              
  Branches      805      805              
==========================================
+ Hits         2496     2498       +2     
+ Misses        329      327       -2     
  Partials       86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

Ensures the migrations collection enforces uniqueness on migration name by syncing indexes at startup, preventing duplicate migration claims and restoring the atomicity guarantee relied on by concurrent boot runners.

Changes:

• Add ensureMigrationIndexes() and call it at the start of migrations.run() to syncIndexes() before any reads/writes.
• Export ensureMigrationIndexes() from the migrations service.
• Add a unit test asserting the Migration schema declares unique: true on name.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
lib/services/migrations.js	Sync Migration indexes on boot (via syncIndexes()) to enforce the unique name constraint before claiming/recording migrations.
modules/core/tests/migrations.unit.tests.js	Add a unit-level assertion that the name schema path declares unique: true.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/services/migrations.js`:
- Around line 132-134: The helper ensureMigrationIndexes directly accesses
mongoose.model('Migration') and calls Migration.syncIndexes(); move this
datastore access into a repository method (e.g., add a
MigrationRepository.syncIndexes or migrationRepo.ensureIndexes) that performs
the mongoose.model('Migration').syncIndexes() call, then update
ensureMigrationIndexes to call that repository method instead so the service
layer no longer imports/uses Mongoose directly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 040682fd-eeb4-4f26-89db-fb4dc4716e01

📥 Commits

Reviewing files that changed from the base of the PR and between 67acceb and bcb28c0.

📒 Files selected for processing (2)

• lib/services/migrations.js
• modules/core/tests/migrations.unit.tests.js

Addressed in de6c666 — mongoose access moved into modules/core/repositories/migration.repository.js; CodeRabbit confirmed the fix in its follow-up review.