Regenerate code from 2025-10, implement schema/read_capacity in BYOCSpec#614
Open
austin-denoble wants to merge 11 commits intomainfrom
Open
Regenerate code from 2025-10, implement schema/read_capacity in BYOCSpec#614austin-denoble wants to merge 11 commits intomainfrom
2025-10, implement schema/read_capacity in BYOCSpec#614austin-denoble wants to merge 11 commits intomainfrom
Conversation
…Schema to use MetadataSchema, add support for schema and read_capacity to BYOCSpec and make sure things are wired properly in request_factory.py
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…ess and BYOC to remove duplication, fix bug when calling parse_non_empty_args for BYOC in __parse_index_spec, add unit tests to cover schema parsing logic
…deserializing spec in get_spec, update unit test to actually validate read_capacity
…xes, implement a unified helper for deserializing read_capacity generally and use in both places, add unit test fixture helpers for creating read_capacity, add unit tests to test_index_model.py
pinecone/core/openapi/db_control/model/read_capacity_dedicated_config.py
Show resolved
Hide resolved
…port configuring read_capacity on both serverless and byoc indexes, add some unit tests to cover logic
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
…oc-metadata-and-drn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the Python client was released for
2025-10, the spec did not yet includeBYOCSpec.read_capacity, so the ability to configure BYOC indexes with DRN is limited through the SDK.Additionally, I noticed we never pulled in
BYOCSpec.schemaeither, so that can be added in as well.Solution
2025-10spec to pull in most recent changes (make generate-oas). We shouldn't need to regenerate grpc for this as the changes are limited toBYOCSpecin the control plane.schemaandread_capacitytoBYOCSpec, and make sure things are wired properly inrequest_factory.py.BackupModelSchemato useMetadataSchema. This was due to an error in the spec wherein theMetadataSchemain the OpenAPI spec did not have anx-component-name. That was fixed here: https://github.com/pinecone-io/apis/pull/417. It's confusing to haveBackupModelSchemaused in all these areas that aren't backup-related.Also pulled in some dependency bumps based on dependabot alerts:
aiohttp(2.6.3)urllib3(3.13.3)filelock(3.21.0)virtualenv(20.31.1)Type of Change
Test Plan
CI - unit, integration, etc
Note
Medium Risk
Touches generated API models plus request/response (de)serialization for index specs, so mismatches could surface at runtime when parsing
spec/read_capacitypayloads. Added tests reduce risk but changes affect core index management flows.Overview
Updates codegen to the
2025-10OpenAPI output and refreshes generated docs/comments (including index-management and vector fetch/query guidance).Extends BYOC index support by adding
read_capacityandschemawiring end-to-end: newByocSpecResponsemodel,ByocSpecdataclass serialization, request factory parsing for BYOCread_capacity/schema, andIndexModelresponse deserialization fixes (manual oneOf handling + shared_deserialize_read_capacity, with relaxed type checking to avoid request/response type mismatches).Renames the generated metadata schema types from
BackupModelSchema*toMetadataSchema*across control-plane models and public interfaces, and expands unit/fixture coverage for schema parsing and BYOC/serverless read-capacity configuration; also tweaks a sparse-index error assertion and Rufftarget-versiontopy310.Written by Cursor Bugbot for commit 1976ce9. This will update automatically on new commits. Configure here.