Skip to content

Update keywords and add check workflow#22153

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
dveeden:update_keywords
Feb 25, 2026
Merged

Update keywords and add check workflow#22153
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
dveeden:update_keywords

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Dec 5, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update keyword checking script and add it to a workflow.

Updates to keywords from:

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Dec 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @dveeden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the existing keyword checking mechanism by replacing a shell script with a more robust and flexible Python script. The primary purpose is to improve the maintainability and adaptability of the keyword validation process, especially by allowing the parser.y definition to be fetched remotely, which can be beneficial for CI/CD pipelines or environments where local file paths might vary.

Highlights

  • Script Renamed and Rewritten: The keyword checking script has been renamed from check-keywords.sh to check-keywords.py and completely rewritten in Python.
  • Flexible Parser Source: The new Python script introduces the ability to specify the parser.y file either from a local path or by downloading it directly from a URL, enhancing flexibility for different environments.
  • Command-Line Arguments: Command-line arguments (--parser_file, --parser_url, --download_from_url) have been added to control the source and method of obtaining the parser.y file.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/keywords.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the keyword checking script, renaming it to check-keywords.py and improving its functionality. The script can now fetch the parser.y file from a URL, which is a great enhancement for flexibility. The code is well-structured. I have a few suggestions to improve robustness, mainly around network error handling and file reading, to make the script even more reliable.

Comment thread scripts/check-keywords.py Outdated
Comment thread scripts/check-keywords.py Outdated
Comment thread scripts/check-keywords.py Outdated
dveeden and others added 2 commits December 5, 2025 13:17
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@dveeden dveeden marked this pull request as ready for review December 5, 2025 12:27
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2025
@dveeden dveeden changed the title Add workflow for keyword checking Update keywords and add check workflow Dec 5, 2025
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 17, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 13, 2026

@bufferflies: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown
Member

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 13, 2026

@0xPoe: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Thanks! :shipit:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Feb 24, 2026
@hfxsd hfxsd mentioned this pull request Feb 24, 2026
14 tasks
@hfxsd hfxsd self-assigned this Feb 24, 2026
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Feb 25, 2026

[LGTM Timeline notifier]

Timeline:

  • 2025-12-17 07:09:43.632823557 +0000 UTC m=+1629728.446601129: ☑️ agreed by breezewish.
  • 2026-02-25 02:12:52.270664189 +0000 UTC m=+234644.785458788: ☑️ agreed by qiancai.

@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Feb 25, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Feb 25, 2026
@hfxsd hfxsd closed this Feb 25, 2026
@hfxsd hfxsd reopened this Feb 25, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 2ba16ab into pingcap:master Feb 25, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants