Skip to content

fix(web): improve chat header badge and title flex distribution #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GuilhermeVieiraDev wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −12
Open

fix(web): improve chat header badge and title flex distribution #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/web/src/components/GitActionsControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ export default function GitActionsControl({ gitCwd, activeThreadId }: GitActions
}
>
<GitQuickActionIcon quickAction={quickAction} />
<span className="sr-only @sm/header-actions:not-sr-only @sm/header-actions:ml-0.5">
<span className="sr-only @3xl/header-actions:not-sr-only @3xl/header-actions:ml-0.5">
{quickAction.label}
</span>
</PopoverTrigger>
Expand All @@ -677,12 +677,12 @@ export default function GitActionsControl({ gitCwd, activeThreadId }: GitActions
onClick={runQuickAction}
>
<GitQuickActionIcon quickAction={quickAction} />
<span className="sr-only @sm/header-actions:not-sr-only @sm/header-actions:ml-0.5">
<span className="sr-only @3xl/header-actions:not-sr-only @3xl/header-actions:ml-0.5">
{quickAction.label}
</span>
</Button>
)}
<GroupSeparator className="hidden @sm/header-actions:block" />
<GroupSeparator className="hidden @3xl/header-actions:block" />
<Menu
onOpenChange={(open) => {
if (open) void invalidateGitQueries(queryClient);
Expand Down
6 changes: 3 additions & 3 deletions apps/web/src/components/ProjectScriptsControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,11 @@ export default function ProjectScriptsControl({
title={`Run ${primaryScript.name}`}
>
<ScriptIcon icon={primaryScript.icon} />
<span className="sr-only @sm/header-actions:not-sr-only @sm/header-actions:ml-0.5">
<span className="sr-only @3xl/header-actions:not-sr-only @3xl/header-actions:ml-0.5">
{primaryScript.name}
</span>
</Button>
<GroupSeparator className="hidden @sm/header-actions:block" />
<GroupSeparator className="hidden @3xl/header-actions:block" />
<Menu highlightItemOnHover={false}>
<MenuTrigger
render={<Button size="icon-xs" variant="outline" aria-label="Script actions" />}
Expand Down Expand Up @@ -342,7 +342,7 @@ export default function ProjectScriptsControl({
) : (
<Button size="xs" variant="outline" onClick={openAddDialog} title="Add action">
<PlusIcon className="size-3.5" />
<span className="sr-only @sm/header-actions:not-sr-only @sm/header-actions:ml-0.5">
<span className="sr-only @3xl/header-actions:not-sr-only @3xl/header-actions:ml-0.5">
Add action
</span>
</Button>
Expand Down
8 changes: 4 additions & 4 deletions apps/web/src/components/chat/ChatHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export const ChatHeader = memo(function ChatHeader({
onToggleDiff,
}: ChatHeaderProps) {
return (
<div className="flex min-w-0 flex-1 items-center gap-2">
<div className="@container/header-actions flex min-w-0 flex-1 items-center gap-2">
<div className="flex min-w-0 flex-1 items-center gap-2 overflow-hidden sm:gap-3">
<SidebarTrigger className="size-7 shrink-0 md:hidden" />
<h2
Expand All @@ -64,8 +64,8 @@ export const ChatHeader = memo(function ChatHeader({
{activeThreadTitle}
</h2>
{activeProjectName && (
<Badge variant="outline" className="min-w-0 shrink truncate">
{activeProjectName}
<Badge variant="outline" className="min-w-0 shrink overflow-hidden">
<span className="min-w-0 truncate">{activeProjectName}</span>
</Badge>
)}
{activeProjectName && !isGitRepo && (
Expand All @@ -74,7 +74,7 @@ export const ChatHeader = memo(function ChatHeader({
</Badge>
)}
</div>
<div className="@container/header-actions flex min-w-0 flex-1 items-center justify-end gap-2 @sm/header-actions:gap-3">
<div className="flex shrink-0 items-center justify-end gap-2 @3xl/header-actions:gap-3">
{activeProjectScripts && (
<ProjectScriptsControl
scripts={activeProjectScripts}
Expand Down
4 changes: 2 additions & 2 deletions apps/web/src/components/chat/OpenInPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,11 @@ export const OpenInPicker = memo(function OpenInPicker({
onClick={() => openInEditor(preferredEditor)}
>
{primaryOption?.Icon && <primaryOption.Icon aria-hidden="true" className="size-3.5" />}
<span className="sr-only @sm/header-actions:not-sr-only @sm/header-actions:ml-0.5">
<span className="sr-only @3xl/header-actions:not-sr-only @3xl/header-actions:ml-0.5">
Open
</span>
</Button>
<GroupSeparator className="hidden @sm/header-actions:block" />
<GroupSeparator className="hidden @3xl/header-actions:block" />
<Menu>
<MenuTrigger render={<Button aria-label="Copy options" size="icon-xs" variant="outline" />}>
<ChevronDownIcon aria-hidden="true" className="size-4" />
Expand Down