Skip to content

Set lensGalley submodule to track updated stable-3_3_0 branch#5483

Merged
asmecher merged 2 commits intopkp:stable-3_3_0from
wopsononock:stable-3_3_0
Apr 21, 2026
Merged

Set lensGalley submodule to track updated stable-3_3_0 branch#5483
asmecher merged 2 commits intopkp:stable-3_3_0from
wopsononock:stable-3_3_0

Conversation

@wopsononock
Copy link
Copy Markdown

Tested this on a fresh install and it allows previously broken viewing of figures and tables in the XML article viewer.

@ctgraham
Copy link
Copy Markdown
Contributor

ctgraham commented Apr 9, 2026

@wopsononock , this will also need a commit to update the submodule hash itself, in addition to the .gitmodules change.

git submodule update plugins/generic/lensGalley
git add plugins/generic/lensGalley
git commit -m 'Update lensGalley to support images without tables'

@ctgraham
Copy link
Copy Markdown
Contributor

@asmecher , @wopsononock and I looked at the failing tests, and we don't believe they are related to the proposed change.

@asmecher asmecher merged commit a0f49a5 into pkp:stable-3_3_0 Apr 21, 2026
11 of 13 checks passed
@asmecher
Copy link
Copy Markdown
Member

Thanks, I've merged this, made similar updates to stable-3_4_0 and stable-3_5_0 and edited the main branch to remove the branch specifier entirely. (We don't generally specify branches on submodules -- the commits speak for themselves. And it's likely to get forgotten going forward when we e.g. split off stable-3_6_0.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants