Draft
Conversation
a9418a1 to
58a4a6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving it as a draft for future reference.
While working on this, I have run into several problems:
dotnet-libp2p:IRemotePeer.DialAsync<T>()is not properly cancellable. It is impossible to timeout with aCancellationToken.IServiceProvideruses severalstaticvariables to track services provided. Most notably, the instance ofIProtocolis stored in astaticHashSet<T>. A service of typeTis retrieved only by its type, hence it is impossible to have severalIServiceProviders for multipleITransports for unit testing.libplanet:dotnet-libp2pstack is designed to have persistent connection between separate peers. That is, to continuously have a channel open withIRemotePeerobtained viaILocalPeer.DialAsync(). The issue may be with the underlying implementation ofIServiceProvideron thedotnet-libp2pside, but regardless, parallel or subsequent calls to a same peer seem very unreliable.