Merged
Conversation
|
aerosol
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes three bugs:
__blank__periods when clicking on a time bucket that includes only comparison data (use the same before/after links as 1) to reproduce)Currently, if the comparison period is longer, the backend fills the "overflow" comparison period with empty metrics, which is not correct, as there is actually data in those buckets.
Hovering anywhere in that right hand side area will display lots of console errors because the graph-tooltip.js module is currently not accounting for missing values. This PR starts doing that to avoid the crash, and on top of that, not even trying to render a tooltip. This will be fixed properly with #6152 and #6159.
Note: I tried to add an E2E test for both of these fixes, but testing the canvas is currently insanely difficult. TODO: write E2E tests once #6159 has rebuilt line-graph as SVG.
Tests
Changelog
Documentation
Dark mode